| Summary: | Untranslatable string in serials search | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Serials | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | colin.campbell |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 9323: Untranslatable string in serial search
Bug 9323 [Counter-proposal] Untranslatable string in serials search Bug 9323 [Counter-proposal] Untranslatable string in serials search Bug 9323 [Counter-proposal] Untranslatable string in serials search |
||
|
Description
Jonathan Druart
2012-12-27 10:26:38 UTC
Created attachment 14289 [details] [review] Bug 9323: Untranslatable string in serial search Test plan: - translate update LANG - Check in your po file that the string "Are you sure you want to reopen this subscription?" does not exist. - Apply the patch - translate update LANG - Check in your po file that the string is translatable Created attachment 14298 [details] [review] Bug 9323 [Counter-proposal] Untranslatable string in serials search The translator seems to have a problem with the _() function inside HTML. Rather than move only the translatable string to the <script> block, why not move all of the JavaScript to the <script> tag? This keeps things a little more organized and lets us follow the guideline to always use double quotes with _(). Same test plan as Jonathan's patch: - translate update LANG - Check in your po file that the string "Are you sure you want to reopen this subscription?" does not exist. - Apply the patch - translate update LANG - Check in your po file that the string is translatable Created attachment 14307 [details] [review] Bug 9323 [Counter-proposal] Untranslatable string in serials search The translator seems to have a problem with the _() function inside HTML. Rather than move only the translatable string to the <script> block, why not move all of the JavaScript to the <script> tag? This keeps things a little more organized and lets us follow the guideline to always use double quotes with _(). Same test plan as Jonathan's patch: - translate update LANG - Check in your po file that the string "Are you sure you want to reopen this subscription?" does not exist. - Apply the patch - translate update LANG - Check in your po file that the string is translatable Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Thanks Owen! Created attachment 15213 [details] [review] Bug 9323 [Counter-proposal] Untranslatable string in serials search The translator seems to have a problem with the _() function inside HTML. Rather than move only the translatable string to the <script> block, why not move all of the JavaScript to the <script> tag? This keeps things a little more organized and lets us follow the guideline to always use double quotes with _(). Same test plan as Jonathan's patch: - translate update LANG - Check in your po file that the string "Are you sure you want to reopen this subscription?" does not exist. - Apply the patch - translate update LANG - Check in your po file that the string is translatable Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> String is now translatable. This patch has been pushed to master. |