Summary: | Patron duplication : should duplicate with empty title (salutation field) | ||
---|---|---|---|
Product: | Koha | Reporter: | Adrien SAURAT <adrien.saurat> |
Component: | Patrons | Assignee: | Adrien SAURAT <adrien.saurat> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | chris, gmcharlt, kyle.m.hall, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
proposed patch
[SIGNED-OFF] Bug 9330: title field empty when duplicating a patron Bug 9330: title field empty when duplicating a patron |
Description
Adrien SAURAT
2012-12-31 11:12:16 UTC
Created attachment 14331 [details] [review] proposed patch Created attachment 14332 [details] [review] [SIGNED-OFF] Bug 9330: title field empty when duplicating a patron For a duplicated patron, the "Saluation" information is now empty by default. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 14991 [details] [review] Bug 9330: title field empty when duplicating a patron For a duplicated patron, the "Saluation" information is now empty by default. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Works as advertised. The need why this salutation should be empty, is not really made clear in the report description btw. But I do not see any harm in it. Passed QA Why shouldn't the salutation be copied by default when duplicating a patron? (In reply to comment #5) > Why shouldn't the salutation be copied by default when duplicating a patron? I would say because the duplicate function would be used most often for members of the same family, where the odds are against everyone having the same title. Thanks for the explanation. That makes sense. This patch has been pushed to master. Pushed to 3.10.x will be in 3.10.6 |