Description
Bernardo Gonzalez Kriegel
2013-01-13 01:59:49 UTC
Created attachment 14550 [details] [review] Bug 9381: Add Catalan languaje Simply add catalan language. No translation yet, so can't be really tested. But it will come soon. Until then, to test: 1) cp misc/translator/po/es-ES* to ca-ES* 2) do perl translate install ca-ES, 3) apply the patch 4) run updatedatabase.pl 5) enable language and display on system preferences. 6) check labels Created attachment 15313 [details] [review] Bug 9381: Add Catalan language Simply add catalan language. No translation yet, so can't be really tested. But it will come soon. Until then, to test: 1) cp misc/translator/po/es-ES* to ca-ES* 2) do perl translate install ca-ES, 3) apply the patch 4) run updatedatabase.pl 5) enable language and display on system preferences. 6) check labels Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Just a note here - the .../data/mysql/en/mandatory/subtag_registry.sql file is in a language specific directory. If you install Koha with German or another language with their own installer, it will not be taken into account :( Katrin, you are right. It's a reasoning error. I was used to modify english versions and then translate, but this files are not translated. I'll provide a followup to others languages. Hi Bernardo, it's a general problem I think - the file should be on the same level as system preferences. But that is way out of scope for your patch. If want to do a patch it would be nice if you could base de-DE on the current en version as I know that others have added more languages there. Created attachment 15424 [details] [review] Followup Bug 9381 - Add Catalan language This followup adds Catalan language into languages other than english. Created attachment 15425 [details] [review] Followup 2 - Bug 9381 - Add Catalan language Sorry, this followup fulfills K. Fischer request to base de-DE file in english one. The differences are small corrections and added languages. Created attachment 15749 [details] [review] Followup Bug 9381 - Add Catalan language This followup adds Catalan language into languages other than english. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 15750 [details] [review] Followup 2 - Bug 9381 - Add Catalan language Sorry, this followup fulfills K. Fischer request to base de-DE file in english one. The differences are small corrections and added languages. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Bernardo, thank you a lot for your patch! Hi Bernardo, I am sorry, but this no longer applies and after rebasing the first patch I can't get the second one to apply. Could you please do it and switch back to signed off? I will put it on top of my list. (In reply to comment #11) > Hi Bernardo, I am sorry, but this no longer applies and after rebasing the > first patch I can't get the second one to apply. Could you please do it and > switch back to signed off? I will put it on top of my list. No problem :) But in a few days! Created attachment 17133 [details] [review] Bug 9381: Add Catalan language Simply add catalan language. No translation yet, so can't be really tested. But it will come soon. Until then, to test: 1) cp misc/translator/po/es-ES* to ca-ES* 2) do perl translate install ca-ES, 3) apply the patch 4) run updatedatabase.pl 5) enable language and display on system preferences. 6) check labels Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Rebased to current master Created attachment 17134 [details] [review] Followup Bug 9381 - Add Catalan language This followup adds Catalan language into languages other than english. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Rebased to master Created attachment 17135 [details] [review] Followup 2 - Bug 9381 - Add Catalan language Sorry, this followup fulfills K. Fischer request to base de-DE file in english one. The differences are small corrections and added languages. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Rebased to master All rebased. Switched to Signed-off Created attachment 17190 [details] [review] [PASSED QA] Bug 9381: Add Catalan language Simply add catalan language. No translation yet, so can't be really tested. But it will come soon. Until then, to test: 1) cp misc/translator/po/es-ES* to ca-ES* 2) do perl translate install ca-ES, 3) apply the patch 4) run updatedatabase.pl 5) enable language and display on system preferences. 6) check labels Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Rebased to current master Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Created attachment 17191 [details] [review] [PASSED QA] Followup Bug 9381 - Add Catalan language This followup adds Catalan language into languages other than english. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Rebased to master Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Created attachment 17192 [details] [review] [PASSED QA] Followup 2 - Bug 9381 - Add Catalan language Sorry, this followup fulfills K. Fischer request to base de-DE file in english one. The differences are small corrections and added languages. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Rebased to master Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> This patch has been pushed to master and 3.12.x. |