Bug 9384

Summary:	With OPACPatronDetails set to 'don't allow' a form shows
Product:	Koha	Reporter:	Nicole C. Engard <nengard>
Component:	Templates	Assignee:	Kyle M Hall (khall) <kyle>
Status:	CLOSED FIXED	QA Contact:	Jonathan Druart <jonathan.druart>
Severity:	normal
Priority:	P5 - low	CC:	jonathan.druart, kyle, veron
Version:	Main
Hardware:	All
OS:	All
URL:	cgi-bin/koha/opac-memberentry.pl
See Also:	http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Bug 9384 - With OPACPatronDetails set to 'don't allow' a form shows Bug 9384 - With OPACPatronDetails set to 'don't allow' a form shows Bug 9384 - With OPACPatronDetails set to 'don't allow' a form shows Bug 9384 - With OPACPatronDetails set to 'don't allow' a form shows

Description Nicole C. Engard 2013-01-14 17:24:17 UTC

In master because of the new feature to allow patrons to register for a card via the opac when you have  OPACPatronDetails  set to 'don't allow' it still shows a from for the patron details, but you can't edit the form. It would be better if this showed as a text display like it used to so that it's not confusing to patrons (even with the note about seeing the librarian).

Nicole

Comment 1 Kyle M Hall (khall) 2013-01-14 19:46:12 UTC

The code for the old form was never removed so it should be trivial to enable Koha to pick which one to show based on whether or not OPAC registration is enabled.

Comment 2 Kyle M Hall (khall) 2013-01-15 12:53:17 UTC Comment hidden (obsolete)

Created attachment 14596 [details] [review]
Bug 9384 - With OPACPatronDetails set to 'don't allow' a form shows

Because of the new feature to allow patrons to register for a card
via the opac when you have OPACPatronDetails  set to 'don't allow'
it still shows a from for the patron details, but you can't edit the form.
It would be better if this showed as a text display like it used to so
that it's not confusing to patrons ( even with the note about seeing
the librarian ).

Comment 3 Kyle M Hall (khall) 2013-01-15 12:56:18 UTC Comment hidden (obsolete)

Created attachment 14597 [details] [review]
Bug 9384 - With OPACPatronDetails set to 'don't allow' a form shows

Because of the new feature to allow patrons to register for a card
via the opac when you have OPACPatronDetails  set to 'don't allow'
it still shows a from for the patron details, but you can't edit the form.
It would be better if this showed as a text display like it used to so
that it's not confusing to patrons ( even with the note about seeing
the librarian ).

Test Plan:
1) Apply patch
2) Log into OPAC
3) Set OPACPatronDetails to "Allow"
4) Refresh the page and click "my personal details"
5) Verify you get the editable form ( opac-memberentry.pl )
6) Set OPACPatronDetails to "Don't allow"
7) Refresh the page and click "my personal details" again
8) Verify you get the non-editable non-form details page ( opac-userupdate.pl )

Comment 4 Liz Rea 2013-01-31 00:18:07 UTC Comment hidden (obsolete)

Created attachment 14966 [details] [review]
Bug 9384 - With OPACPatronDetails set to 'don't allow' a form shows

Because of the new feature to allow patrons to register for a card
via the opac when you have OPACPatronDetails  set to 'don't allow'
it still shows a from for the patron details, but you can't edit the form.
It would be better if this showed as a text display like it used to so
that it's not confusing to patrons ( even with the note about seeing
the librarian ).

Test Plan:
1) Apply patch
2) Log into OPAC
3) Set OPACPatronDetails to "Allow"
4) Refresh the page and click "my personal details"
5) Verify you get the editable form ( opac-memberentry.pl )
6) Set OPACPatronDetails to "Don't allow"
7) Refresh the page and click "my personal details" again
8) Verify you get the non-editable non-form details page ( opac-userupdate.pl )

Signed-off-by: Liz Rea <liz@catalyst.net.nz>
Passes tests, works as advertised

Comment 5 Jonathan Druart 2013-01-31 08:52:03 UTC

QA comment:
Works as expected, simple patch.
Marked as Passed QA.

Comment 6 Jonathan Druart 2013-01-31 08:52:18 UTC

Created attachment 14971 [details] [review]
Bug 9384 - With OPACPatronDetails set to 'don't allow' a form shows

Because of the new feature to allow patrons to register for a card
via the opac when you have OPACPatronDetails  set to 'don't allow'
it still shows a from for the patron details, but you can't edit the form.
It would be better if this showed as a text display like it used to so
that it's not confusing to patrons ( even with the note about seeing
the librarian ).

Test Plan:
1) Apply patch
2) Log into OPAC
3) Set OPACPatronDetails to "Allow"
4) Refresh the page and click "my personal details"
5) Verify you get the editable form ( opac-memberentry.pl )
6) Set OPACPatronDetails to "Don't allow"
7) Refresh the page and click "my personal details" again
8) Verify you get the non-editable non-form details page ( opac-userupdate.pl )

Signed-off-by: Liz Rea <liz@catalyst.net.nz>
Passes tests, works as advertised

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Comment 7 Jared Camins-Esakov 2013-01-31 19:30:47 UTC

This patch works as far as it goes, but it does not add any check to opac-memberentry.pl to redirect the user if they end up on that page with OPACPatronDetails set to "Don't allow," and it really needs to before I push it.

Comment 8 Jonathan Druart 2013-02-01 08:32:47 UTC

(In reply to comment #7)
> This patch works as far as it goes, but it does not add any check to
> opac-memberentry.pl to redirect the user if they end up on that page with
> OPACPatronDetails set to "Don't allow," and it really needs to before I push
> it.

So I think the followup will delete some tests in the opac-memberentry.tt template ([% IF OPACPatronDetails %]).

Comment 9 Marc Véron 2016-05-23 15:20:58 UTC

Is this bug still valid?

Comment 10 Owen Leonard 2016-05-23 15:37:10 UTC

As far as I can tell this is no longer valid.