| Summary: | patron add labels right aligned in chrome | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | bgkriegel, chris, jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | /cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=499&category_type=A | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
label to the right
Bug 9385 - patron add labels right aligned in chrome Bug 9385 - patron add labels right aligned in chrome [SIGNED-OFF] Bug 9385 - patron add labels right aligned in chrome Bug 9385 - patron add labels right aligned in chrome |
||
Created attachment 15250 [details] [review] Bug 9385 - patron add labels right aligned in chrome The <legend> element has been given right alignment which seems to only be respected by WebKit-based browsers. Users of Chrome and Safari see a right-aligned legend while others see a left-aligned one. Given that the legend is often applied to fieldsets spanning much of the screen it seems wiser to have them left-aligned. This patch removes "text-align:right" from the CSS so that <legend> will inherit the default left alignment. To test, view any page with a legend element, for instance the patron add form. In Firefox, Chrome, Safari, IE, etc. the legend ("Patron identity," "Main address," etc.) should be left-aligned in the fieldset. Created attachment 15251 [details] [review] Bug 9385 - patron add labels right aligned in chrome The <legend> element has been given right alignment which seems to only be respected by WebKit-based browsers. Users of Chrome and Safari see a right-aligned legend while others see a left-aligned one. Given that the legend is often applied to fieldsets spanning much of the screen it seems wiser to have them left-aligned. This patch removes "text-align:right" from the CSS so that <legend> will inherit the default left alignment. To test, view any page with a legend element, for instance the patron add form. In Firefox, Chrome, Safari, IE, etc. the legend ("Patron identity," "Main address," etc.) should be left-aligned in the fieldset. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works as described. Tested in IE, Chrome, Firefox, Opera. No errors. Created attachment 15264 [details] [review] [SIGNED-OFF] Bug 9385 - patron add labels right aligned in chrome The <legend> element has been given right alignment which seems to only be respected by WebKit-based browsers. Users of Chrome and Safari see a right-aligned legend while others see a left-aligned one. Given that the legend is often applied to fieldsets spanning much of the screen it seems wiser to have them left-aligned. This patch removes "text-align:right" from the CSS so that <legend> will inherit the default left alignment. To test, view any page with a legend element, for instance the patron add form. In Firefox, Chrome, Safari, IE, etc. the legend ("Patron identity," "Main address," etc.) should be left-aligned in the fieldset. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works as described. Tested in IE, Chrome, Firefox, Opera. No errors. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All tests pass QA comment: This patch fixes the described issues in Chromium and does not introduced any change with Firefox. Marked as Passed QA. Created attachment 15325 [details] [review] Bug 9385 - patron add labels right aligned in chrome The <legend> element has been given right alignment which seems to only be respected by WebKit-based browsers. Users of Chrome and Safari see a right-aligned legend while others see a left-aligned one. Given that the legend is often applied to fieldsets spanning much of the screen it seems wiser to have them left-aligned. This patch removes "text-align:right" from the CSS so that <legend> will inherit the default left alignment. To test, view any page with a legend element, for instance the patron add form. In Firefox, Chrome, Safari, IE, etc. the legend ("Patron identity," "Main address," etc.) should be left-aligned in the fieldset. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works as described. Tested in IE, Chrome, Firefox, Opera. No errors. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All tests pass Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This patch has been pushed to master. Pushed to 3.8.x and 3.10.x will be in 3.8.11 and 3.10.4 |
Created attachment 14571 [details] label to the right In Chrome when adding/editing a patron the labels are aligned to the right instead of the left like in Firefox. See attached