| Summary: | Feedback message for FAILED check out items are not obvious for visually impaired | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Corey <agent.075> |
| Component: | Staff interface | Assignee: | Corey <agent.075> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | gmcharlt, julian.maurice, kyle, liz, m.de.rooy, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Fixed Patch
bug 9387 - Feedback Message for FAILED Check Out Items are not obvious for Visually Impaired. Bug 9387 - Feedback message for FAILED check out items are not obvious for visually impaired Bug 9387 - Feedback message for FAILED check out items are not obvious for visually impaired Bug 9387 - Feedback message for FAILED check out items are not obvious for visually impaired |
||
|
Description
Corey
2013-01-15 00:51:52 UTC
Created attachment 14576 [details] [review] Fixed Patch Created attachment 14581 [details] [review] bug 9387 - Feedback Message for FAILED Check Out Items are not obvious for Visually Impaired. testing procedure: 1. search for Patron. 2. issue an item that is not existing. E.g. "asdf" <-- Assuming that this is not in your test data... 3. Verify that the Error Message is apparent & visually doesn't look bad. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Error message has new heading, doesn't look bad. QA Comment: Corey, first thanks for sending a patch! But when aiming for consistency, putting one message into a <h3> and many other messages like this on several forms not, might not be the best idea. Another thought here: If the visually impaired benefit from this, could we make a Koha syspref for a start. And work through all messages on a form basis? Just an idea.. Also note that I had the bullet now on line 1 and the words on line 2. Smaller laptop screen.. Created attachment 49989 [details] [review] Bug 9387 - Feedback message for FAILED check out items are not obvious for visually impaired This patch adds a heading to the error dialg displayed when a barcode has been submitted for checkout which doesn't exist. This patch also modifies the markup of the error dialog in order to make error a little more clear to sighted users. To test, apply the patch and submit a barcode for checkout which does not exist. The resulting error dialog should have a heading, "Barcode not found." Created attachment 50028 [details] [review] Bug 9387 - Feedback message for FAILED check out items are not obvious for visually impaired This patch adds a heading to the error dialg displayed when a barcode has been submitted for checkout which doesn't exist. This patch also modifies the markup of the error dialog in order to make error a little more clear to sighted users. To test, apply the patch and submit a barcode for checkout which does not exist. The resulting error dialog should have a heading, "Barcode not found." Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 50049 [details] [review] Bug 9387 - Feedback message for FAILED check out items are not obvious for visually impaired This patch adds a heading to the error dialg displayed when a barcode has been submitted for checkout which doesn't exist. This patch also modifies the markup of the error dialog in order to make error a little more clear to sighted users. To test, apply the patch and submit a barcode for checkout which does not exist. The resulting error dialog should have a heading, "Barcode not found." Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for the May 2016 release. Thanks Owen! Patch pushed to 3.22.x, will be in 3.22.7 |