Summary: | Some corrections and additions to about.tt | ||
---|---|---|---|
Product: | Koha | Reporter: | Vitor Fernandes <vfernandes> |
Component: | About | Assignee: | Vitor Fernandes <vfernandes> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | bgkriegel, m.de.rooy, mjr |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 9418: Some corrections and additions to about.tt
Bug 9418: Some corrections and additions to about.tt Bug 9418: Some corrections and additions to about.tt Bug 9418: Some corrections and additions to about.tt [SIGNED-OFF] Bug 9418: Some corrections and additions to about.tt Bug 9418: Some corrections and additions to about.tt |
Description
Vitor Fernandes
2013-01-17 14:34:49 UTC
Created attachment 14672 [details] Bug 9418: Some corrections and additions to about.tt Test plan: - Apply patch - See if KEEP SOLUTIONS and C & P Bibliography Services - Software Coop should be now software.coop Created attachment 14673 [details] [review] Bug 9418: Some corrections and additions to about.tt Test plan: - Apply patch - See if KEEP SOLUTIONS and C & P Bibliography Services - Software Coop should be now software.coop Sponsored-by: KEEP SOLUTIONS Sorry, the coding guideline "Templates are expected to be valid XHTML" http://wiki.koha-community.org/wiki/Coding_Guidelines means that should be & not & there. There's also a question of where C & P should be in the list - do we ignore & (so it's sorted as CPB, so it would be the last C entry now), regard & as its own letter (usually after z in English, I think, so it would be the last C entry now) or regard it as "and" (placing CandP between Cal.. and Cat..)? But for any of those, it wouldn't be the first C. I wouldn't have refused to sign for that alone, though. I will correct the problem with the &. Let me know where to put C & P... Created attachment 14694 [details] [review] Bug 9418: Some corrections and additions to about.tt Replaced & with & according codelines. Sponsored-by: KEEP SOLUTIONS Created attachment 14868 [details] [review] Bug 9418: Some corrections and additions to about.tt Test plan: - Apply patch - See if KEEP SOLUTIONS and C & P Bibliography Services - Software Coop should be now software.coop Bug 9418: Some corrections and additions to about.tt Replaced & with & according codelines. Sponsored-by: KEEP SOLUTIONS Combined to patches into one. Reorder C-entries as per sort order. Vitor, I combined your 2 patches AND sorted C-entries. As MJ said, C & P comes last through sort. Regards Created attachment 14889 [details] [review] [SIGNED-OFF] Bug 9418: Some corrections and additions to about.tt Test plan: - Apply patch - See if KEEP SOLUTIONS and C & P Bibliography Services - Software Coop should be now software.coop Bug 9418: Some corrections and additions to about.tt Replaced & with & according codelines. Sponsored-by: KEEP SOLUTIONS Combined to patches into one. Reorder C-entries as per sort order. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 14999 [details] [review] Bug 9418: Some corrections and additions to about.tt Test plan: - Apply patch - See if KEEP SOLUTIONS and C & P Bibliography Services - Software Coop should be now software.coop Bug 9418: Some corrections and additions to about.tt Replaced & with & according codelines. Sponsored-by: KEEP SOLUTIONS Combined to patches into one. Reorder C-entries as per sort order. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Trivial change. Passing QA since Jared is RM and can answer now if he agrees with the addition of C&P in the list. (I assume you contacted him about that already..) From the comments of MJ Ray in the report I assume implicit agreement from his part on the other modification. Hi Marcel, Yes it was Jared that told me in the Koha IRC, so there isn't any problem with that. This patch has been pushed to master. |