| Summary: | Use DataTables on Authorized Values page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | bgkriegel, jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 9429 - Use DataTables on Authorized Values page
Bug 9429 - Use DataTables on Authorized Values page Bug 9429 - Use DataTables on Authorized Values page Bug 9429 [Revised] Use DataTables on Authorized Values page [SIGNED-OFF] Bug 9429 [Revised] Use DataTables on Authorized Values page Bug 9429 [Revised] Use DataTables on Authorized Values page |
||
|
Description
Owen Leonard
2013-01-18 19:19:33 UTC
Created attachment 14709 [details] [review] Bug 9429 - Use DataTables on Authorized Values page Replace the tablesorter plugin with the DataTables plugin on the Authorized Values page. To test, open the Authorized Values page (Administration -> Authorized values). Confirm that table sorting works correctly. Created attachment 14748 [details] [review] Bug 9429 - Use DataTables on Authorized Values page Replace the tablesorter plugin with the DataTables plugin on the Authorized Values page. To test, open the Authorized Values page (Administration -> Authorized values). Confirm that table sorting works correctly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the "All" entry. Created attachment 14881 [details] [review] Bug 9429 - Use DataTables on Authorized Values page Replace the tablesorter plugin with the DataTables plugin on the Authorized Values page. To test, open the Authorized Values page (Administration -> Authorized values). Confirm that table sorting works correctly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the "All" entry. Created attachment 15692 [details] [review] Bug 9429 [Revised] Use DataTables on Authorized Values page Replace the tablesorter plugin with the DataTables plugin on the Authorized Values page. To test, open the Authorized Values page (Administration -> Authorized values). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. Created attachment 15738 [details] [review] [SIGNED-OFF] Bug 9429 [Revised] Use DataTables on Authorized Values page Replace the tablesorter plugin with the DataTables plugin on the Authorized Values page. To test, open the Authorized Values page (Administration -> Authorized values). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. QA comment: This patch replaces tablesorter with datatables on the authorized values page. All works great. Just one small remark: the "no limitation" is sorted after the "XXX limitations". But it is not blocker at all. Marked as Passed QA. Created attachment 15879 [details] [review] Bug 9429 [Revised] Use DataTables on Authorized Values page Replace the tablesorter plugin with the DataTables plugin on the Authorized Values page. To test, open the Authorized Values page (Administration -> Authorized values). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the aLengthMenu key for DataTables This patch has been pushed to master. |