| Summary: | Use DataTables on library transfer limits page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | bgkriegel, jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 18965 | ||
| Attachments: |
Bug 9430 - Use DataTables on library transfer limits page
Bug 9430 - Use DataTables on library transfer limits page Bug 9430 - Use DataTables on library transfer limits page Bug 9430 [Revised] Use DataTables on library transfer limits page [SIGNED-OFF] Bug 9430 [Revised] Use DataTables on library transfer limits page Bug 9430 [Revised] Use DataTables on library transfer limits page |
||
|
Description
Owen Leonard
2013-01-18 19:42:31 UTC
Created attachment 14713 [details] [review] Bug 9430 - Use DataTables on library transfer limits page Replace the tablesorter plugin with the DataTables plugin on the library transfer limits page. Also made minor changes to "check/uncheck all" function to prevent page from jumping on click, and removed unused function. To test, open the library transfer limits page (Administration -> Library transfer limits). Confirm that table sorting works correctly for all tables. Test that the "check all/uncheck all" links still work correctly. Created attachment 14749 [details] [review] Bug 9430 - Use DataTables on library transfer limits page Replace the tablesorter plugin with the DataTables plugin on the library transfer limits page. Also made minor changes to "check/uncheck all" function to prevent page from jumping on click, and removed unused function. To test, open the library transfer limits page (Administration -> Library transfer limits). Confirm that table sorting works correctly for all tables. Test that the "check all/uncheck all" links still work correctly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the "All" entry. Created attachment 14882 [details] [review] Bug 9430 - Use DataTables on library transfer limits page Replace the tablesorter plugin with the DataTables plugin on the library transfer limits page. Also made minor changes to "check/uncheck all" function to prevent page from jumping on click, and removed unused function. To test, open the library transfer limits page (Administration -> Library transfer limits). Confirm that table sorting works correctly for all tables. Test that the "check all/uncheck all" links still work correctly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the "All" entry. Created attachment 15693 [details] [review] Bug 9430 [Revised] Use DataTables on library transfer limits page Replace the tablesorter plugin with the DataTables plugin on the library transfer limits page. Also made minor changes to "check/uncheck all" function to prevent page from jumping on click, and removed unused function. To test, open the library transfer limits page (Administration -> Library transfer limits). Confirm that table sorting works correctly for all tables. Test that the "check all/uncheck all" links still work correctly. Revision corrects template path to datatables assets. Created attachment 15739 [details] [review] [SIGNED-OFF] Bug 9430 [Revised] Use DataTables on library transfer limits page Replace the tablesorter plugin with the DataTables plugin on the library transfer limits page. Also made minor changes to "check/uncheck all" function to prevent page from jumping on click, and removed unused function. To test, open the library transfer limits page (Administration -> Library transfer limits). Confirm that table sorting works correctly for all tables. Test that the "check all/uncheck all" links still work correctly. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. QA comment: This patch replaces tablesorter with datatable on the branch transfer limits page. A little ergonomic issue: the table in the first tab has not the same width as others (the "min-width: 50%;" is not adequate). Marked as Passed QA. Created attachment 15880 [details] [review] Bug 9430 [Revised] Use DataTables on library transfer limits page Replace the tablesorter plugin with the DataTables plugin on the library transfer limits page. Also made minor changes to "check/uncheck all" function to prevent page from jumping on click, and removed unused function. To test, open the library transfer limits page (Administration -> Library transfer limits). Confirm that table sorting works correctly for all tables. Test that the "check all/uncheck all" links still work correctly. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the aLengthMenu key for DataTables + delete an unused div block (used for pager) This patch has been pushed to master. |