Summary: | acqui/addorderiso2409.pl is not Plack-friendly | ||
---|---|---|---|
Product: | Koha | Reporter: | Jared Camins-Esakov <jcamins> |
Component: | Acquisitions | Assignee: | Jared Camins-Esakov <jcamins> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | major | ||
Priority: | P5 - low | CC: | chris, jonathan.druart, mirko |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 9432: Plack changes for acqui/addorderiso2409.pl
Bug 9432: Plack changes for acqui/addorderiso2409.pl Bug 9432: Plack changes for acqui/addorderiso2409.pl |
Description
Jared Camins-Esakov
2013-01-19 00:33:40 UTC
Created attachment 14722 [details] [review] Bug 9432: Plack changes for acqui/addorderiso2409.pl Without this patch, after selecting the file I want to add acquisitions from, Plack explodes. With this patch, it works. To test without Plack: 1) Apply patch. 2) Try adding an order item from a staged file. 3) If it works, there are no regressions from the patch. To test with Plack: 1) Try adding an order item from a staged file. It will fail. 2) Apply patch. 3) Try adding an order item from a staged file. 3) If it works, the patch is successful. Created attachment 15080 [details] [review] Bug 9432: Plack changes for acqui/addorderiso2409.pl Without this patch, after selecting the file I want to add acquisitions from, Plack explodes. With this patch, it works. To test without Plack: 1) Apply patch. 2) Try adding an order item from a staged file. 3) If it works, there are no regressions from the patch. To test with Plack: 1) Try adding an order item from a staged file. It will fail. 2) Apply patch. 3) Try adding an order item from a staged file. 3) If it works, the patch is successful. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Fixes Plack, does not break Apache. Works as expected. Simple patch, works with Plack and Apache. Marked as Passed QA. Created attachment 15100 [details] [review] Bug 9432: Plack changes for acqui/addorderiso2409.pl Without this patch, after selecting the file I want to add acquisitions from, Plack explodes. With this patch, it works. To test without Plack: 1) Apply patch. 2) Try adding an order item from a staged file. 3) If it works, there are no regressions from the patch. To test with Plack: 1) Try adding an order item from a staged file. It will fail. 2) Apply patch. 3) Try adding an order item from a staged file. 3) If it works, the patch is successful. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Fixes Plack, does not break Apache. Works as expected. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This patch has been pushed to master. Pushed to 3.10.x will be in 3.10.3 |