Summary: | Use DataTables on cities administration page | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | bgkriegel, jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 9436 - Use DataTables on cities administration page
Bug 9436 - Use DataTables on cities administration page Bug 9436 - Use DataTables on cities administration page Bug 9436 [Revised] Use DataTables on cities administration page [SIGNED-OFF] Bug 9436 [Revised] Use DataTables on cities administration page Bug 9436 [Revised] Use DataTables on cities administration page Bug 9436 [Revised] Use DataTables on cities administration page |
Description
Owen Leonard
2013-01-20 00:47:53 UTC
Created attachment 14724 [details] [review] Bug 9436 - Use DataTables on cities administration page Replace the tablesorter plugin with the DataTables plugin on the cities administration page. To test, open the cities administration page (Administration -> Cities and towns). Confirm that table sorting works correctly. Created attachment 14751 [details] [review] Bug 9436 - Use DataTables on cities administration page Replace the tablesorter plugin with the DataTables plugin on the cities administration page. To test, open the cities administration page (Administration -> Cities and towns). Confirm that table sorting works correctly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the "All" entry. Created attachment 14884 [details] [review] Bug 9436 - Use DataTables on cities administration page Replace the tablesorter plugin with the DataTables plugin on the cities administration page. To test, open the cities administration page (Administration -> Cities and towns). Confirm that table sorting works correctly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the "All" entry. Created attachment 15697 [details] [review] Bug 9436 [Revised] Use DataTables on cities administration page Replace the tablesorter plugin with the DataTables plugin on the cities administration page. To test, open the cities administration page (Administration -> Cities and towns). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. Created attachment 15741 [details] [review] [SIGNED-OFF] Bug 9436 [Revised] Use DataTables on cities administration page Replace the tablesorter plugin with the DataTables plugin on the cities administration page. To test, open the cities administration page (Administration -> Cities and towns). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Sorting works. No errors. QA comment: This patch replaces tablesorter with datatable on the cities admin page. The pagination is not "four_button" I don't know if it is deliberate. Marked as Passed QA. Created attachment 15882 [details] [review] Bug 9436 [Revised] Use DataTables on cities administration page Replace the tablesorter plugin with the DataTables plugin on the cities administration page. To test, open the cities administration page (Administration -> Cities and towns). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Sorting works. No errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the aLengthMenu key for DataTables + delete an unused div block (used for pager) This conflicts with the Bootstrap button for creating a new city. Created attachment 16139 [details] [review] Bug 9436 [Revised] Use DataTables on cities administration page Replace the tablesorter plugin with the DataTables plugin on the cities administration page. To test, open the cities administration page (Administration -> Cities and towns). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. Further revision corrects conflict with Bug 9630 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Sorting works. No errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the aLengthMenu key for DataTables + delete an unused div block (used for pager) Please update the status if you think it's incorrect to return this to "Passed QA." This patch has been pushed to master. |