|
Description
Owen Leonard
2013-01-22 17:32:58 UTC
Created attachment 14755 [details] [review] Bug 9445 - Use DataTables in local use system preferences editor Replace the tablesorter plugin with the DataTables plugin in the local use system preferences editor. This patch moves embedding of the toolbar and table-sorting JS from within the body of the page to the <head> for sake of consistency. To test, open the system preferences editor to the Local Use tab. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. Created attachment 14771 [details] [review] Bug 9445 - Use DataTables in local use system preferences editor Replace the tablesorter plugin with the DataTables plugin in the local use system preferences editor. This patch moves embedding of the toolbar and table-sorting JS from within the body of the page to the <head> for sake of consistency. To test, open the system preferences editor to the Local Use tab. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 15700 [details] [review] Bug 9445 [Revised] Use DataTables in local use system preferences editor Replace the tablesorter plugin with the DataTables plugin in the local use system preferences editor. This patch moves embedding of the toolbar and table-sorting JS from within the body of the page to the <head> for sake of consistency. To test, open the system preferences editor to the Local Use tab. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets. Created attachment 15744 [details] [review] [SIGNED-OFF] Bug 9445 [Revised] Use DataTables in local use system preferences editor Replace the tablesorter plugin with the DataTables plugin in the local use system preferences editor. This patch moves embedding of the toolbar and table-sorting JS from within the body of the page to the <head> for sake of consistency. To test, open the system preferences editor to the Local Use tab. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Tab sorting works. No errors. QA comment: Add datatable on the systempreferences.pl page (local use only). Marked as Passed QA. Created attachment 15775 [details] [review] Bug 9445 [Revised] Use DataTables in local use system preferences editor Replace the tablesorter plugin with the DataTables plugin in the local use system preferences editor. This patch moves embedding of the toolbar and table-sorting JS from within the body of the page to the <head> for sake of consistency. To test, open the system preferences editor to the Local Use tab. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Tab sorting works. No errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This patch adds Datatables, but it does not remove tablesorter from the page. It probably should. (In reply to comment #7) > This patch adds Datatables, but it does not remove tablesorter from the > page. It probably should. Ho yes, good catch. I don't understand when this code is used but it should be deleted. Created attachment 15810 [details] [review] Bug 9445 [Revised] Use DataTables in local use system preferences editor Replace the tablesorter plugin with the DataTables plugin in the local use system preferences editor. This patch moves embedding of the toolbar and table-sorting JS from within the body of the page to the <head> for sake of consistency. To test, open the system preferences editor to the Local Use tab. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Tab sorting works. No errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Further revision removes old tablesorter code Returning to "Passed QA" as per jcamins' instructions. This patch has been pushed to master. |