|
Description
Owen Leonard
2013-01-22 17:56:48 UTC
Created attachment 14756 [details] [review] Bug 9446 - Use DataTables on Z39.50 servers administration page Replace the tablesorter plugin with the DataTables plugin on the Z39.50 servers administration page. Structural changes were made to deal with a DataTables bug which prevents it from properly parsing a <th> with a colspan. This patch also moves embedding of the toolbar and table-sorting JS from within the body of the page to the <head> for sake of consistency. To test, open the Z39.50 servers administration page (Administration -> Z39.50 client targets). Confirm that table sorting works correctly. Created attachment 14772 [details] [review] Bug 9446 - Use DataTables on Z39.50 servers administration page Replace the tablesorter plugin with the DataTables plugin on the Z39.50 servers administration page. Structural changes were made to deal with a DataTables bug which prevents it from properly parsing a <th> with a colspan. This patch also moves embedding of the toolbar and table-sorting JS from within the body of the page to the <head> for sake of consistency. To test, open the Z39.50 servers administration page (Administration -> Z39.50 client targets). Confirm that table sorting works correctly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 15701 [details] [review] Bug 9446 [Revised] Use DataTables on Z39.50 servers administration page Replace the tablesorter plugin with the DataTables plugin on the Z39.50 servers administration page. Structural changes were made to deal with a DataTables bug which prevents it from properly parsing a <th> with a colspan. This patch also moves embedding of the toolbar and table-sorting JS from within the body of the page to the <head> for sake of consistency. To test, open the Z39.50 servers administration page (Administration -> Z39.50 client targets). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. Created attachment 15745 [details] [review] [SIGNED-OFF] Bug 9446 [Revised] Use DataTables on Z39.50 servers administration page Replace the tablesorter plugin with the DataTables plugin on the Z39.50 servers administration page. Structural changes were made to deal with a DataTables bug which prevents it from properly parsing a <th> with a colspan. This patch also moves embedding of the toolbar and table-sorting JS from within the body of the page to the <head> for sake of consistency. To test, open the Z39.50 servers administration page (Administration -> Z39.50 client targets). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Table sorting works. No errors. QA comment: This patch replaces tablesorter with datatable on the z3950 servers admin page. Marked as Passed QA. Created attachment 15884 [details] [review] Bug 9446 [Revised] Use DataTables on Z39.50 servers administration page Replace the tablesorter plugin with the DataTables plugin on the Z39.50 servers administration page. Structural changes were made to deal with a DataTables bug which prevents it from properly parsing a <th> with a colspan. This patch also moves embedding of the toolbar and table-sorting JS from within the body of the page to the <head> for sake of consistency. To test, open the Z39.50 servers administration page (Administration -> Z39.50 client targets). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Table sorting works. No errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Add the aLengthMenu key for DataTables This patch has been pushed to master. This patch has been reverted from master at the request of the author. Per discussion with Owen, I am going to re-merge this patch. Actually, disregard my last comment. This patch re-adds the YUI toolbar. Created attachment 16097 [details] [review] Bug 9446 [Revised] Use DataTables on Z39.50 servers administration page Replace the tablesorter plugin with the DataTables plugin on the Z39.50 servers administration page. Structural changes were made to deal with a DataTables bug which prevents it from properly parsing a <th> with a colspan. This patch also moves embedding of the toolbar and table-sorting JS from within the body of the page to the <head> for sake of consistency. To test, open the Z39.50 servers administration page (Administration -> Z39.50 client targets). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. Further revision fixes conflict with Bug 9647. Patch tested with a sandbox, by Frederic Durand <frederic.durand@unilim.fr> Created attachment 16506 [details] [review] Bug 9446 [Revised] Use DataTables on Z39.50 servers administration page Replace the tablesorter plugin with the DataTables plugin on the Z39.50 servers administration page. Structural changes were made to deal with a DataTables bug which prevents it from properly parsing a <th> with a colspan. This patch also moves embedding of the toolbar and table-sorting JS from within the body of the page to the <head> for sake of consistency. To test, open the Z39.50 servers administration page (Administration -> Z39.50 client targets). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. Further revision fixes conflict with Bug 9647. Signed-off-by: Frederic Durand <frederic.durand@unilim.fr> QA comment: This patch replaces tablesorter with datatable on the z3950 servers admin page. Marked as Passed QA. Created attachment 16523 [details] [review] Bug 9446 [Revised] Use DataTables on Z39.50 servers administration page Replace the tablesorter plugin with the DataTables plugin on the Z39.50 servers administration page. Structural changes were made to deal with a DataTables bug which prevents it from properly parsing a <th> with a colspan. This patch also moves embedding of the toolbar and table-sorting JS from within the body of the page to the <head> for sake of consistency. To test, open the Z39.50 servers administration page (Administration -> Z39.50 client targets). Confirm that table sorting works correctly. Revision corrects template path to datatables assets. Further revision fixes conflict with Bug 9647. Signed-off-by: Frederic Durand <frederic.durand@unilim.fr> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This patch has been pushed to master. |