Bug 9450

Summary: Use DataTables in cataloging Z39.50 search results
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Jonathan Druart <jonathan.druart>
Severity: enhancement    
Priority: P5 - low CC: bgkriegel, gmcharlt, jonathan.druart
Version: Main   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on:    
Bug Blocks: 9747    
Attachments: Bug 9450 - Use DataTables in cataloging Z39.50 search results
sort issue
Bug 9450 - Use DataTables in cataloging Z39.50 search results
Bug 9450 [Revised] Use DataTables in cataloging Z39.50 search results
[SIGNED-OFF] Bug 9450 [Revised] Use DataTables in cataloging Z39.50 search results
Bug 9450 [Revised] Use DataTables in cataloging Z39.50 search results

Description Owen Leonard 2013-01-22 20:08:03 UTC
The cataloging Z39.50 search results window uses the old tablesorter plugin. It should use the DataTables plugin.
Comment 1 Owen Leonard 2013-01-22 20:12:52 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2013-01-23 09:15:13 UTC
Created attachment 14774 [details]
sort issue

Owen,

I don't know why this table is not sort correctly.

Please see the screenshot.
Comment 3 Owen Leonard 2013-01-29 15:41:37 UTC
(In reply to comment #2)
> I don't know why this table is not sort correctly.

I can't reproduce this problem. Is the problem only with that search, or with any? Is the problem only with title sort?
Comment 4 Galen Charlton 2013-02-06 06:24:57 UTC Comment hidden (obsolete)
Comment 5 Galen Charlton 2013-02-06 06:31:14 UTC
I've signed off on the patch after testing.

I was able to reproduce the title sorting issue that Jonathan saw (connecting to z3950.bnf.fr/TOUT, character encoding ISO 5426), but that problem also existed with the old tablesorter plugin and, in fact, has nothing to do with either jQuery plugin -- the sorting is thrown off by embedded NSB/NSE characters in the title.  That's worth opening a separate bug.
Comment 6 Owen Leonard 2013-02-26 16:43:03 UTC Comment hidden (obsolete)
Comment 7 Bernardo Gonzalez Kriegel 2013-02-27 23:56:10 UTC Comment hidden (obsolete)
Comment 8 Jonathan Druart 2013-03-05 10:14:35 UTC
QA comment:

I got the sort issue but as Galen said it caused by the NSB/NSE characters (\x88Les \x89). I opened a new bug (bug 9747).

Marked as Passed QA.
Comment 9 Jonathan Druart 2013-03-05 10:15:01 UTC
Created attachment 15885 [details] [review]
Bug 9450 [Revised] Use DataTables in cataloging Z39.50 search results

Replace the tablesorter plugin with the DataTables plugin in cataloging
Z39.50 search results.

Structural changes were made to the table markup to deal with a
DataTables bug which prevents it from properly parsing a <th> with a
colspan.

To test, go to cataloging and perform a Z39.50 search. Confirm that
table sorting works correctly. In this configuration there
should be no pager and no results filtering.

Revision corrects template path to datatables assets.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Sorting works. No errors.
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 10 Jared Camins-Esakov 2013-03-07 15:38:55 UTC
This patch has been pushed to master.