| Summary: | borrower_stats.pl gives off warnings and is not Plack-compatible | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jared Camins-Esakov <jcamins> |
| Component: | Reports | Assignee: | Jared Camins-Esakov <jcamins> |
| Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | chris, jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 9451: Quiet warnings and Plackify borrower_stats.pl
Bug 9451: Quiet warnings and Plackify borrower_stats.pl Bug 9451: Quiet warnings and Plackify borrower_stats.pl |
||
|
Description
Jared Camins-Esakov
2013-01-22 23:37:04 UTC
Created attachment 14763 [details] [review] Bug 9451: Quiet warnings and Plackify borrower_stats.pl There are several warnings and one non-Plack-compatible variable in reports/borrower_stats.pl. To test: 1) Apply patch 2) Use the borrower report wizard to create a report that includes an extended patron attribute. 3) Check the logs, and make sure that you don't see any of the following messages: Variable "$period" is not available at /home/jcamins/kohaclone/reports/borrowers_stats.pl line 265. Use of uninitialized value in hash element at /home/jcamins/kohaclone/reports/borrowers_stats.pl line 375. Use of uninitialized value in hash element at /home/jcamins/kohaclone/reports/borrowers_stats.pl line 376. Created attachment 15153 [details] [review] Bug 9451: Quiet warnings and Plackify borrower_stats.pl There are several warnings and one non-Plack-compatible variable in reports/borrower_stats.pl. To test: 1) Apply patch 2) Use the borrower report wizard to create a report that includes an extended patron attribute. 3) Check the logs, and make sure that you don't see any of the following messages: Variable "$period" is not available at /home/jcamins/kohaclone/reports/borrowers_stats.pl line 265. Use of uninitialized value in hash element at /home/jcamins/kohaclone/reports/borrowers_stats.pl line 375. Use of uninitialized value in hash element at /home/jcamins/kohaclone/reports/borrowers_stats.pl line 376. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> QA comment: Looks good. The patch removes some warning in the log file under Plack. No behavior changed under Apache. Note: some others warnings still exist (subroutine foo redefined). Marked as Passed QA. Created attachment 15157 [details] [review] Bug 9451: Quiet warnings and Plackify borrower_stats.pl There are several warnings and one non-Plack-compatible variable in reports/borrower_stats.pl. To test: 1) Apply patch 2) Use the borrower report wizard to create a report that includes an extended patron attribute. 3) Check the logs, and make sure that you don't see any of the following messages: Variable "$period" is not available at /home/jcamins/kohaclone/reports/borrowers_stats.pl line 265. Use of uninitialized value in hash element at /home/jcamins/kohaclone/reports/borrowers_stats.pl line 375. Use of uninitialized value in hash element at /home/jcamins/kohaclone/reports/borrowers_stats.pl line 376. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This patch has been pushed to master. Pushed to 3.10.x will be in 3.10.3 Comment on attachment 15157 [details] [review] Bug 9451: Quiet warnings and Plackify borrower_stats.pl Review of attachment 15157 [details] [review]: ----------------------------------------------------------------- ::: reports/borrowers_stats.pl @@ +56,4 @@ > $filters[3]=format_date_in_iso($filters[3]); > $filters[4]=format_date_in_iso($filters[4]); > my $digits = $input->param("digits"); > +our $period = $input->param("period"); Hmm, i still think our is kinda hacky, but it works |