Summary: | Use DataTables on saved reports page | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jonathan.druart, nengard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/reports/guided_reports.pl?phase=Use saved | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 9466 - Use DataTables on saved reports page
Bug 9466 [Revised] Use DataTables on saved reports page Bug 9466 [Revised] Use DataTables on saved reports page Bug 9466 [Revised] Use DataTables on saved reports page [SIGNED-OFF] Bug 9466 [Revised] Use DataTables on saved reports page Bug 9466 [Revised] Use DataTables on saved reports page Bug 9466 [Revised] Use DataTables on saved reports page |
Description
Owen Leonard
2013-01-23 19:09:20 UTC
Created attachment 14799 [details] [review] Bug 9466 - Use DataTables on saved reports page Replace the tablesorter plugin with the DataTables plugin on the saved reports page. To test, open the saved reports page (Reports > Use saved). Confirm that table sorting works correctly. Hi Owen, I found a bug in all the datatable patchs :-/ The iDisplayLength value equal 20 but this value is not in the aLengthMenu, so the selected value is 10. The default values of datatable is 10, 25, 50 and 100. We have 2 solutions: 1/ we defined the aLengthMenu with 10, 20, 50, 100, All 2/ the iDisplayLength has to be equal to 25 Created attachment 14856 [details] [review] Bug 9466 [Revised] Use DataTables on saved reports page Replace the tablesorter plugin with the DataTables plugin on the saved reports page. To test, open the saved reports page (Reports > Use saved). Confirm that table sorting works correctly. Revision makes default result count (20) match options for number of pagination entries (10,20,50,100,all). Created attachment 14878 [details] [review] Bug 9466 [Revised] Use DataTables on saved reports page Replace the tablesorter plugin with the DataTables plugin on the saved reports page. To test, open the saved reports page (Reports > Use saved). Confirm that table sorting works correctly. Revision makes default result count (20) match options for number of pagination entries (10,20,50,100,all). Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> *** Bug 9568 has been marked as a duplicate of this bug. *** Created attachment 15705 [details] [review] Bug 9466 [Revised] Use DataTables on saved reports page Replace the tablesorter plugin with the DataTables plugin on the saved reports page. To test, open the saved reports page (Reports > Use saved). Confirm that table sorting works correctly. Revision makes default result count (20) match options for number of pagination entries (10,20,50,100,all). Further revision corrects template path to datatables assets. Created attachment 15833 [details] [review] [SIGNED-OFF] Bug 9466 [Revised] Use DataTables on saved reports page Replace the tablesorter plugin with the DataTables plugin on the saved reports page. To test, open the saved reports page (Reports > Use saved). Confirm that table sorting works correctly. Revision makes default result count (20) match options for number of pagination entries (10,20,50,100,all). Further revision corrects template path to datatables assets. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> QA comment: On the reports/guided_reports.pl page, I got a js error: ReferenceError: dt_add_type_uk_date is not defined (js/datatables.js is only loaded if saved1 is defined). Marked as Failed QA Created attachment 16135 [details] [review] Bug 9466 [Revised] Use DataTables on saved reports page Replace the tablesorter plugin with the DataTables plugin on the saved reports page. To test, open the saved reports page (Reports > Use saved). Confirm that table sorting works correctly. Revision makes default result count (20) match options for number of pagination entries (10,20,50,100,all). Further revision corrects template path to datatables assets. Further revision fixes JavaScript error as reported by QA Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Please update the status if you think it's incorrect to keep this "signed off." QA comment: This patch replaces tablesorter with DataTables on the saved reports page. No js error with the last patch. Marked as Passed QA. Created attachment 16158 [details] [review] Bug 9466 [Revised] Use DataTables on saved reports page Replace the tablesorter plugin with the DataTables plugin on the saved reports page. To test, open the saved reports page (Reports > Use saved). Confirm that table sorting works correctly. Revision makes default result count (20) match options for number of pagination entries (10,20,50,100,all). Further revision corrects template path to datatables assets. Further revision fixes JavaScript error as reported by QA Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This patch has been pushed to master. |