| Summary: | Use DataTables on serials claims page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | f.demians, jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | /cgi-bin/koha/serials/claims.pl | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 9471 - Use DataTables on serials claims page
Signed-off patch Bug 9471 - Use DataTables on serials claims page |
||
|
Description
Owen Leonard
2013-01-23 20:25:12 UTC
Created attachment 14803 [details] [review] Bug 9471 - Use DataTables on serials claims page Replace the tablesorter plugin with the DataTables plugin on the serials claims page. This patch replaces some custom table fitlering code with code which uses DataTables' built-in table fitlering. A minor correction to markup has also been made to properly align inputs in the filter form. To test, run the serials claims report for a vendor with data which will populate results. Confirm that table sorting works correctly. Confirm also that filtering by title and branch works. Created attachment 15205 [details] [review] Signed-off patch Works as advertised. I have compared side by side the both pages, with tablesorter, and with DataTables. The both work. No regression. With DataTables, no more sorting on Begin clam column, which is great. A new sort option may be useful on the Library column (wasn't the with tablesorter neither). QA comment: All filters and sorts work. It would be great to use the DataTables's filters instead of a "manual" way. I proposed a patch (http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8910) in order to use the DT server-side processing for this table, but the first step (Bug 5342) is waiting signoffs for a long time. Marked as Passed QA. Created attachment 15227 [details] [review] Bug 9471 - Use DataTables on serials claims page Replace the tablesorter plugin with the DataTables plugin on the serials claims page. This patch replaces some custom table fitlering code with code which uses DataTables' built-in table fitlering. A minor correction to markup has also been made to properly align inputs in the filter form. To test, run the serials claims report for a vendor with data which will populate results. Confirm that table sorting works correctly. Confirm also that filtering by title and branch works. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Works as advertised. I have compared side by side the both pages, with tablesorter, and with DataTables. The both work. No regression. With DataTables, no more sorting on Begin clam column, which is great. A new sort option may be usefull on the Library column (wasn't the with tablesorter neither). Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This patch has been pushed to master. |