| Summary: | Use Datatables on Koha news page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | gmcharlt, jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | /cgi-bin/koha/tools/koha-news.pl | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Attachments: |
Bug 9476 - Use Datatables on Koha news page
Bug 9476 - Use Datatables on Koha news page Bug 9476 [Revised] Use Datatables on Koha news page Bug 9476: Use Datatables on Koha news page Bug 9476: Use Datatables on Koha news page |
||
|
Description
Owen Leonard
2013-01-24 01:37:32 UTC
Created attachment 14806 [details] [review] Bug 9476 - Use Datatables on Koha news page Replace the tablesorter plugin with the DataTables plugin on the Koha news page. To test, open the Koha news page (Tools -> News). Confirm that table sorting works correctly. Patch doesn't apply to master -- please rebase and resubmit. Created attachment 15099 [details] [review] Bug 9476 - Use Datatables on Koha news page Replace the tablesorter plugin with the DataTables plugin on the Koha news page. To test, open the Koha news page (Tools -> News). Confirm that table sorting works correctly. With the revised patch, I get the following error: Template process failed: file error - parse error - /home/gmc/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt line 202: unexpected end of input at /home/gmc/koha/C4/Templates.pm line 132. Looks like the "[% IF ( opac_news_count ) %]" introduced by the patch isn't closed. Created attachment 15109 [details] [review] Bug 9476 [Revised] Use Datatables on Koha news page Replace the tablesorter plugin with the DataTables plugin on the Koha news page. To test, open the Koha news page (Tools -> News). Confirm that table sorting works correctly. Revision corrects merge error after rebase. Created attachment 15113 [details] [review] Bug 9476: Use Datatables on Koha news page Replace the tablesorter plugin with the DataTables plugin on the Koha news page. To test, open the Koha news page (Tools -> News). Confirm that table sorting works correctly. Signed-off-by: Galen Charlton <gmc@esilibrary.com> QA comment: Replace tablesorter with datatable on the koha-news tool page. Works great. Marked as Passed QA. Created attachment 15131 [details] [review] Bug 9476: Use Datatables on Koha news page Replace the tablesorter plugin with the DataTables plugin on the Koha news page. To test, open the Koha news page (Tools -> News). Confirm that table sorting works correctly. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This patch has been pushed to master. |