Summary: | confirmations for user holds in opac are not translatable | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | I18N/L10N | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, f.demians, jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942 | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed patch
[SIGNED-OFF] Bug 9493: confirmations for user holds in opac are not translatable Bug 9493: confirmations for user holds in opac are not translatable |
Description
Fridolin Somers
2013-01-25 15:02:26 UTC
Created attachment 14862 [details] [review] Proposed patch See commit message Created attachment 14890 [details] [review] [SIGNED-OFF] Bug 9493: confirmations for user holds in opac are not translatable In opac-user.tt, javascript for user holds confirmations (cancel, suspend, resume) are not translatable. This is because text is in onclick attribute, withtout javascript method for translatable strings : _(). This patch moves those strings as variables into script tag and sets them translatable. Test plan : - set a hold for a user - Go to OPAC user page "my summary" - click on "Cancel" => you get a confirmation message - click on "Suspend all holds" => you get a confirmation message - click on "Resume all suspended holds" => you get a confirmation message Test this is 'en' and another language. Signed-off-by: Owen Leonard <oleonard@myacpl.org> QA comment: This patch makes 3 strings translatable at the OPAC. Marked as Passed QA. Created attachment 15142 [details] [review] Bug 9493: confirmations for user holds in opac are not translatable In opac-user.tt, javascript for user holds confirmations (cancel, suspend, resume) are not translatable. This is because text is in onclick attribute, withtout javascript method for translatable strings : _(). This patch moves those strings as variables into script tag and sets them translatable. Test plan : - set a hold for a user - Go to OPAC user page "my summary" - click on "Cancel" => you get a confirmation message - click on "Suspend all holds" => you get a confirmation message - click on "Resume all suspended holds" => you get a confirmation message Test this is 'en' and another language. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This patch has been pushed to master. Pushed to 3.10.x and 3.8.x will be in 3.10.3 and 3.8.10 Wrong bug... sorry for changes. |