Summary: | GetNormalizedISBN only ever checks the first populated ISBN field | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
Component: | Architecture, internals, and plumbing | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | NEW --- | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | CC: | barton, d.gavio, egpetridis, jonathan.druart, mathsabypro, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: | MARCXML file with multiple ISBN numbers -- ISBN-13 first |
Description
Kyle M Hall (khall)
2013-01-28 13:16:00 UTC
Created attachment 32608 [details]
MARCXML file with multiple ISBN numbers -- ISBN-13 first
Stage and import this record.
Oh, the badness goes *so* much deeper: GetNormalizedISBN calls _isbn_cleanup(): sub _isbn_cleanup { my ($isbn) = @_; return NormalizeISBN( { isbn => $isbn, format => 'ISBN-10', strip_hyphens => 1, } ) if $isbn; } ... So if the first ISBN isn't a valid *10 digit* isbn, GetNormalizedISBN will fail. I've attached a MARCXML record which will trigger the bug. Could you describe an issue visible on the interface? |