Summary: | [3.8.X] famfamfam: wrongly placed in package 3.8.8/9 | ||
---|---|---|---|
Product: | Koha | Reporter: | vinod <vinod_librarian> |
Component: | OPAC | Assignee: | Chris Cormack <chris> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, m.de.rooy, tomascohen |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 9502 - famfamfam wronly linked in 3.8.x
Signed off patch Bug 9502 - Wrong destination in cp command (INSTALL.opensuse!) Bug 9502 - Wrong destination in cp command (INSTALL.opensuse!) |
Description
vinod
2013-01-29 10:52:18 UTC
Created attachment 15308 [details] [review] Bug 9502 - famfamfam wronly linked in 3.8.x famfamfam icon set was moved from 'prog' to 'lib' but there still are wrong references to the old path. This patch fixes it. Note: it is not a .deb packages problem but a more general one. Sponsored-by: Universidad Nacional de Córdoba Created attachment 15309 [details] [review] Signed off patch Question: If prog should be lib, should that be too in blib? Look at the copy destination for these lines e.g.: +cp koha-tmpl/opac-tmpl/lib/famfamfam/silk/error_go.png blib/OPAC_TMPL_DIR/prog/famfamfam/silk/error_go.png -cp koha-tmpl/opac-tmpl/prog/famfamfam/mini/note.gif blib/OPAC_TMPL_DIR/prog/famfamfam/mini/note.gif +cp koha-tmpl/opac-tmpl/lib/famfamfam/mini/note.gif blib/OPAC_TMPL_DIR/prog/famfamfam/mini/note.gif Created attachment 16838 [details] [review] Bug 9502 - Wrong destination in cp command (INSTALL.opensuse!) As noted on the bug by Marcel, the patch fails to acknowledge the path change properly in the INSTALL.opensuse file. This patch fixes that documentation error, if anyone is willing to apply it. Regards To+ PS: The original patch has been applied already or fixed by another patch. Created attachment 17516 [details] [review] Bug 9502 - Wrong destination in cp command (INSTALL.opensuse!) As noted on the bug by Marcel, the patch fails to acknowledge the path change properly in the INSTALL.opensuse file. This patch fixes that documentation error, if anyone is willing to apply it. Regards To+ PS: The original patch has been applied already or fixed by another patch. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Looks good to me. Updating patch status.. Just for the record: Lines referring to prog/famfamfam are still in this INSTALL doc also on master.. Pushed to 3.8.x will be in 3.8.12 |