| Summary: | Update default LOC Z39.50 target | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Bernardo Gonzalez Kriegel <bgkriegel> |
| Component: | Z39.50 / SRU / OpenSearch Servers | Assignee: | Bernardo Gonzalez Kriegel <bgkriegel> |
| Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | chris, jonathan.druart, kyle, m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 9494 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 9520 - Update default LOC Z39.50 target
[SIGNED-OFF] Bug 9520 - Update default LOC Z39.50 target Bug 9520 -[Revised] - Update default LOC Z39.50 target Bug 9520 -[Revised] - Update default LOC Z39.50 target |
||
|
Description
Bernardo Gonzalez Kriegel
2013-01-31 19:20:31 UTC
Created attachment 14983 [details] [review] Bug 9520 - Update default LOC Z39.50 target This patch updates (if present) target settings of Library of Congress Z39.50 server. Created attachment 15004 [details] [review] [SIGNED-OFF] Bug 9520 - Update default LOC Z39.50 target This patch updates (if present) target settings of Library of Congress Z39.50 server. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> QA comment:
The query is not the good one, mysql raises a warning:
Data truncated for column 'type' at row 4
type is an enum (cf kohastructure: `type` enum('zed','opensearch') NOT NULL default 'zed')
Marked as Failed QA.
(In reply to comment #3) > QA comment: > > The query is not the good one, mysql raises a warning: > Data truncated for column 'type' at row 4 > type is an enum (cf kohastructure: `type` enum('zed','opensearch') NOT NULL > default 'zed') > > Marked as Failed QA. Sorry but.. did the comment applies to this bug? bgkriegel@sentey:~/kohaclone$ mysql -uUUU -pPPP kohadev --verbose -e "UPDATE z3950servers SET host = 'lx2.loc.gov', port = 210, db = 'LCDB', type = 'USMARC', encoding = 'utf8' WHERE name = 'LIBRARY OF CONGRESS'" -------------- UPDATE z3950servers SET host = 'lx2.loc.gov', port = 210, db = 'LCDB', type = 'USMARC', encoding = 'utf8' WHERE name = 'LIBRARY OF CONGRESS' -------------- No warnings :) (In reply to comment #4) > Sorry but.. did the comment applies to this bug? Yes! mysql> show create table z3950servers; [...] `type` enum('zed','opensearch') NOT NULL DEFAULT 'zed', [...] mysql> UPDATE z3950servers SET host = 'lx2.loc.gov', port = 210, db = 'LCDB', type = 'USMARC', encoding = 'utf8' WHERE name = 'LIBRARY OF CONGRESS'; Query OK, 0 rows affected, 1 warning (0.06 sec) Rows matched: 1 Changed: 0 Warnings: 1 mysql> show warnings; +---------+------+-------------------------------------------+ | Level | Code | Message | +---------+------+-------------------------------------------+ | Warning | 1265 | Data truncated for column 'type' at row 4 | +---------+------+-------------------------------------------+ 1 row in set (0.00 sec) mysql> select type from z3950servers where name='LIBRARY OF CONGRESS'; +------+ | type | +------+ | | +------+ 1 row in set (0.00 sec) Created attachment 15769 [details] [review] Bug 9520 -[Revised] - Update default LOC Z39.50 target This patch updates (if present) target settings of Library of Congress Z39.50 server. Revision: Was trying to update wrong column 'type', now correct column 'syntax'. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> (In reply to comment #6) > Bug 9494 does not update the type column. It doesn't need to. The correct column to update is 'syntax'. I was fooled by the name. I'm sorry (again). (In reply to comment #8) > (In reply to comment #6) > > Bug 9494 does not update the type column. > It doesn't need to. The correct column to update is 'syntax'. > I was fooled by the name. I'm sorry (again). Don't worry, thanks for your quick revised patch! Now it is good. This patch updates the LOC z3950 server for current installations. Marked as Passed QA. Created attachment 15771 [details] [review] Bug 9520 -[Revised] - Update default LOC Z39.50 target This patch updates (if present) target settings of Library of Congress Z39.50 server. Revision: Was trying to update wrong column 'type', now correct column 'syntax'. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: add the SetVersion call This patch has been pushed to master. Pushed to 3.8.x and 3.10.x will be in 3.8.11 and 3.10.4 |