Summary: | Fix Import Marc Bibliographic Framework Text Label | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 9545 - Fix import MARC bibliographic framework text label
[SIGNED-OFF] Bug 9545 - Fix import MARC bibliographic framework text label [SIGNED-OFF] Bug 9545 - Fix import MARC bibliographic framework text label Bug 9545 - Fix import MARC bibliographic framework text label Bug 9545 - Followup Fix import MARC bibliographic framework text label |
Description
David Cook
2013-02-05 01:09:40 UTC
Created attachment 15240 [details] [review] Bug 9545 - Fix import MARC bibliographic framework text label This patch improves the labeling of import controls on the MARC frameworks page by making import options more explicit. Other changes: - Form markup fixed to match standard form constructions - JavaScript corrected to make more embedded English strings translatable. - Form labels made clickable by making "for" attributes match unique form field ids. - Some warning re-worded for readability and translatability. - Large "loading" icon replaced with more proportional smaller one. To test, view the MARC frameworks page (admin/biblio_framework.pl) and test Export and Import functionality. Clicking each should display a form with options clearly labeled. Import and Export operations should complete correctly. Add this to the list of operations that would be better handled by a modal dialog--perhaps via jQueryUI or Bootstrap if we find we can replace Greybox with one of them. Created attachment 15288 [details] [review] [SIGNED-OFF] Bug 9545 - Fix import MARC bibliographic framework text label This patch improves the labeling of import controls on the MARC frameworks page by making import options more explicit. Other changes: - Form markup fixed to match standard form constructions - JavaScript corrected to make more embedded English strings translatable. - Form labels made clickable by making "for" attributes match unique form field ids. - Some warning re-worded for readability and translatability. - Large "loading" icon replaced with more proportional smaller one. To test, view the MARC frameworks page (admin/biblio_framework.pl) and test Export and Import functionality. Clicking each should display a form with options clearly labeled. Import and Export operations should complete correctly. Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described, although I see what Owen means about it being a good candidate for replacement with a modal dialog box in the future. Created attachment 15289 [details] [review] [SIGNED-OFF] Bug 9545 - Fix import MARC bibliographic framework text label This patch improves the labeling of import controls on the MARC frameworks page by making import options more explicit. Other changes: - Form markup fixed to match standard form constructions - JavaScript corrected to make more embedded English strings translatable. - Form labels made clickable by making "for" attributes match unique form field ids. - Some warning re-worded for readability and translatability. - Large "loading" icon replaced with more proportional smaller one. To test, view the MARC frameworks page (admin/biblio_framework.pl) and test Export and Import functionality. Clicking each should display a form with options clearly labeled. Import and Export operations should complete correctly. Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described, although I see what Owen means about it being a good candidate for replacement with a modal dialog box in the future. QA comment: Works great. The export action for the default framework don't work. I will provide a followup. Owen, yesterday for dialogs I found Bootbox.js (http://bootboxjs.com). Perhaps it could be useful for us. Marked as Passed QA. TODO: some code could be factorize (default framework and others). Created attachment 15321 [details] [review] Bug 9545 - Fix import MARC bibliographic framework text label This patch improves the labeling of import controls on the MARC frameworks page by making import options more explicit. Other changes: - Form markup fixed to match standard form constructions - JavaScript corrected to make more embedded English strings translatable. - Form labels made clickable by making "for" attributes match unique form field ids. - Some warning re-worded for readability and translatability. - Large "loading" icon replaced with more proportional smaller one. To test, view the MARC frameworks page (admin/biblio_framework.pl) and test Export and Import functionality. Clicking each should display a form with options clearly labeled. Import and Export operations should complete correctly. Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described, although I see what Owen means about it being a good candidate for replacement with a modal dialog box in the future. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 15322 [details] [review] Bug 9545 - Followup Fix import MARC bibliographic framework text label The export action for the default framework did not work. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Last patch just replaces input type="button" with input type="submit" This patch has been pushed to master. Pushed to 3.8.x and 3.10.x will be in 3.8.11 and 3.10.4 |