Summary: | Remove problematic IE CSS Hacks in staff client | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | Templates | Assignee: | David Cook <dcook> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | CC: | veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: | Bug 9584 - Remove problematic IE CSS Hacks in staff client |
Description
David Cook
2013-02-11 03:30:12 UTC
Created attachment 15214 [details] [review] Bug 9584 - Remove problematic IE CSS Hacks in staff client To test: Before applying patch... 1) Open up Internet Explorer 6 or a newer version of Internet Explorer and use the F12 Developer Tools to change the Document Mode to Quirks Mode 2) Conduct a search on the staff client that will generate a high number of hits. (e.g. "e" as an unlimited query, if you have a maximum of a few thousand records.) 3) Note that you can't access the page options at the bottom of the page and that your result list is cut off at the bottom, and thus inaccessible. Apply patch... 4) Refresh your browser (preferably using F5 or whatever other method you use to bypass the browser's cache), and re-run the search if necessary 5) Note that you are now able to see the full page of search results, plus the paging at the bottom As far as I can tell, there are no regressions, but feel free to search for them. Afaik, there are no doc1 or doc2 ids, and I can't see any problems with any elements with doc3 IDs. (In reply to comment #0) > While we might not want to support older versions of IE, this is problematic > behaviour, and it shouldn't be happening. I'm not sure of the origin of > these hacks, but it looks like we should remove them. Unfortunately removing these lines of CSS breaks the functionality of the fixed-footer language chooser when you have multiple languages enabled. git blame works well in this case for digging up original intentions. If we are to fix this (and I'm not convinced we should fix bugs which only affect IE7 and earlier) we'll need a solution that doesn't break the language chooser. Still valid? (In reply to Marc Véron from comment #3) > Still valid? No. The CSS in question has long been removed. |