| Summary: | Fix spelling mistake in default tab conditional for opac-detail | ||
|---|---|---|---|
| Product: | Koha | Reporter: | David Cook <dcook> |
| Component: | OPAC | Assignee: | David Cook <dcook> |
| Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | chris, jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 9585 - Fix spelling mistake in default tab conditional for opac-detail
[SIGNED-OFF] Bug 9585 - Fix spelling mistake in default tab conditional for opac-detail Bug 9585 - Fix spelling mistake in default tab conditional for opac-detail |
||
|
Description
David Cook
2013-02-11 05:26:04 UTC
Created attachment 15215 [details] [review] Bug 9585 - Fix spelling mistake in default tab conditional for opac-detail Test Plan: The easiest way to test is just to double-check the other strings in the conditional which say "subscriptions" rather than "subscription". You can also look at opac-detail.tt where the param is shown, and note that there is no condition for "subscription" - just "subscriptions". Any tests other than that would be overly complex for such a trivial patch. It looks to me like you'd have to have a UNIMARC setup to really fully test it ("Please note that the Serial Collection tab is currently available only for UNIMARC"). But testing the "subscriptions" and "holdings" settings of the opacSerialDefaultTab shows the correct behavior, the change does appear to be logical.
Created attachment 15261 [details] [review] [SIGNED-OFF] Bug 9585 - Fix spelling mistake in default tab conditional for opac-detail There is just a small typo where one of the results of a conditional is "subscription" rather than "subscriptions". If this comes up, the correct tab (subscriptions) will not be chosen. I'm not sure what will happen...it'll probably just have the "holdings", "subscriptions", and "serial collection" tabs all default to closed with none of them being open. Test Plan: The easiest way to test is just to double-check the other strings in the conditional which say "subscriptions" rather than "subscription". You can also look at opac-detail.tt where the param is shown, and note that there is no condition for "subscription" - just "subscriptions". Any tests other than that would be overly complex for such a trivial patch. Signed-off-by: Owen Leonard <oleonard@myacpl.org> QA comment: In opac-detail.tt, the test is on the string "subscriptions". Marked as Passed QA. Created attachment 15274 [details] [review] Bug 9585 - Fix spelling mistake in default tab conditional for opac-detail There is just a small typo where one of the results of a conditional is "subscription" rather than "subscriptions". If this comes up, the correct tab (subscriptions) will not be chosen. I'm not sure what will happen...it'll probably just have the "holdings", "subscriptions", and "serial collection" tabs all default to closed with none of them being open. Test Plan: The easiest way to test is just to double-check the other strings in the conditional which say "subscriptions" rather than "subscription". You can also look at opac-detail.tt where the param is shown, and note that there is no condition for "subscription" - just "subscriptions". Any tests other than that would be overly complex for such a trivial patch. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This patch has been pushed to master. Pushed to 3.8.x and 3.10.x will be in 3.8.11 and 3.10.4 |