| Summary: | Remove $ENV{DEBUG} info from Member Template | ||
|---|---|---|---|
| Product: | Koha | Reporter: | David Cook <dcook> |
| Component: | Templates | Assignee: | David Cook <dcook> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | chris, elliott, kyle |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 9586 - Remove $ENV{DEBUG} info from Member Template
Bug 9586 - Remove $ENV{DEBUG} info from Member Template Bug 9586 - Remove $ENV{DEBUG} info from Member Template |
||
Created attachment 15216 [details] [review] Bug 9586 - Remove $ENV{DEBUG} info from Member Template Test Plan: Before applying patch... 1) Modify koha-httpd.conf, and add the following line, in the virtualhost (if it does not already exist): SetEnv DEBUG 1 2) Restart/reload Apache 3) Go to Add a New Patron 4) Note that the message "Debug is on (level 1)" appears at the top of the page above the patron entry form After applying patch... 5) Reload the patron add/edit page 6) Note that the message "Debug is on (level 1)" no longer appears 7) Change your koha-httpd.conf settings back as necessary... Created attachment 15351 [details] [review] Bug 9586 - Remove $ENV{DEBUG} info from Member Template Currently, if $ENV{DEBUG} is set (for example to 1), the debug level will be printed on the Add/Edit Patron pages (memberentrygen.tt) in the form of: "Debug is on (level 1)". While many if not most folks might not set $ENV{DEBUG} on a production system, there is no reason to have this information printing on the member template(s). No where else in Koha is there a template that prints $ENV{DEBUG} information, with the exception of calendar.inc, although that doesn't activate until at least debug level 2 or 5, so it might be worth holding on to. It is certainly more complicated than simply printing the debug level. I don't do development on the calendars, so I'm not going to address that one. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 15894 [details] [review] Bug 9586 - Remove $ENV{DEBUG} info from Member Template Currently, if $ENV{DEBUG} is set (for example to 1), the debug level will be printed on the Add/Edit Patron pages (memberentrygen.tt) in the form of: "Debug is on (level 1)". While many if not most folks might not set $ENV{DEBUG} on a production system, there is no reason to have this information printing on the member template(s). No where else in Koha is there a template that prints $ENV{DEBUG} information, with the exception of calendar.inc, although that doesn't activate until at least debug level 2 or 5, so it might be worth holding on to. It is certainly more complicated than simply printing the debug level. I don't do development on the calendars, so I'm not going to address that one. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Elliott Davis <elliott@bywatersolions.com> This patch has been pushed to master. Pushed to 3.8.x and 3.10.x will be in 3.8.11 and 3.10.4 |
Currently, if $ENV{DEBUG} is set (for example to 1), the debug level will be printed on the Add/Edit Patron pages (memberentrygen.tt) in the form of: "Debug is on (level 1)". While many if not most folks might not set $ENV{DEBUG} on a production system, there is no reason to have this information printing on the member template(s). No where else in Koha is there a template that prints $ENV{DEBUG} information, with the exception of calendar.inc, although that doesn't activate until at least debug level 2 or 5, so it might be worth holding on to. It is certainly more complicated than simply printing the debug level. I don't do development on the calendars, so I'm not going to address that one.