Summary: | rotating collections permissions are wrong | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Tools | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | normal | ||
Priority: | P5 - low | CC: | kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 8836 | ||
Bug Blocks: | |||
Attachments: |
Proposed patch
Bug 9605: rotating collections permissions are wrong [PASSED QA] Bug 9605: rotating collections permissions are wrong |
Description
Fridolin Somers
2013-02-13 09:28:30 UTC
Created attachment 15292 [details] [review] Proposed patch See commit comment Hi Fridolyn, while the code for rotating collections is in Koha it was deactivated last minute before release due to some security concerns. Kyle has opened a bug to resurrect it bug 8836. I have linked your bug with Kyle's. Created attachment 15294 [details] [review] Bug 9605: rotating collections permissions are wrong In tools / rotating collections, permissions are 'parameters => 1'. But there is a dedicated permission : tools => rotating_collections. Test plan : - Disable tools/rotating_collections permission to your connected user - Check you dont have access to those pages : rotating_collections/addItems.pl rotating_collections/editCollections.pl rotating_collections/rotatingCollections.pl rotating_collections/transferCollection.pl - Enable tools/rotating_collections permission to your connected user - Check you have access to above pages Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> This dependson resurrection of rotating collections which won't go in before 3.14 now. Taking another look at this - it fixes a permission and will allow to block access to rotating collections using the right permission. So this is a bug for master. Created attachment 17064 [details] [review] [PASSED QA] Bug 9605: rotating collections permissions are wrong In tools / rotating collections, permissions are 'parameters => 1'. But there is a dedicated permission : tools => rotating_collections. Test plan : - Disable tools/rotating_collections permission to your connected user - Check you dont have access to those pages : rotating_collections/addItems.pl rotating_collections/editCollections.pl rotating_collections/rotatingCollections.pl rotating_collections/transferCollection.pl - Enable tools/rotating_collections permission to your connected user - Check you have access to above pages Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixes wrong permission on rotating collection related pages. This will allow to block access to those. This patch has been pushed to master. |