Summary: | Replace YUI menu on patrons page with Bootstrap | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | bgkriegel |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/members/members-home.pl | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 9616 - Replace YUI menu on patrons page with Bootstrap
Bug 9616 - Replace YUI menu on patrons page with Bootstrap [SIGNED-OFF] Bug 9616 - Replace YUI menu on patrons page with Bootstrap [PASSED QA] Bug 9616 - Replace YUI menu on patrons page with Bootstrap |
Description
Owen Leonard
2013-02-15 14:38:23 UTC
Created attachment 15362 [details] [review] Bug 9616 - Replace YUI menu on patrons page with Bootstrap This patch converts the toolbar include file used to create the "New patron" menu to Bootstrap, replacing YUI button and menu code with Bootstrap markup. To test, view any page which uses patron-toolbar.inc (members-home.pl or circulation.pl after searching for a non-existent patron). Button and menu should look correct and work correctly with the AddPatronLists preference in both states. Bug 9420 has been pushed to master. Why this patch removes conflicting lines from that bug? -<<<<<<< HEAD ... -======= ... ->>>>>>> Bug 9420 [Revised] Work on Bootstrap for Koha -<<<<<<< HEAD ... ->>>>>>> Bug 9420 [Revised] Work on Bootstrap for Koha Created attachment 15368 [details] [review] Bug 9616 - Replace YUI menu on patrons page with Bootstrap This patch converts the toolbar include file used to create the "New patron" menu to Bootstrap, replacing YUI button and menu code with Bootstrap markup. To test, view any page which uses patron-toolbar.inc (members-home.pl or circulation.pl after searching for a non-existent patron). Button and menu should look correct and work correctly with the AddPatronLists preference in both states. Sorry for the bad merge errors in the previous patch! Created attachment 15370 [details] [review] [SIGNED-OFF] Bug 9616 - Replace YUI menu on patrons page with Bootstrap This patch converts the toolbar include file used to create the "New patron" menu to Bootstrap, replacing YUI button and menu code with Bootstrap markup. To test, view any page which uses patron-toolbar.inc (members-home.pl or circulation.pl after searching for a non-existent patron). Button and menu should look correct and work correctly with the AddPatronLists preference in both states. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works as described. No errors. Looks very good! Created attachment 15452 [details] [review] [PASSED QA] Bug 9616 - Replace YUI menu on patrons page with Bootstrap This patch converts the toolbar include file used to create the "New patron" menu to Bootstrap, replacing YUI button and menu code with Bootstrap markup. To test, view any page which uses patron-toolbar.inc (members-home.pl or circulation.pl after searching for a non-existent patron). Button and menu should look correct and work correctly with the AddPatronLists preference in both states. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works as described. No errors. Looks very good! Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, no problems found. This patch has been pushed to master. |