| Summary: | Replace YUI menu on catalog pages with Bootstrap | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | bgkriegel, jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | /cgi-bin/koha/members/detail.pl | ||
| Change sponsored?: | --- | Patch complexity: | Medium patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 9617 - Replace YUI menu on catalog pages with Bootstrap
[SIGNED-OFF] Bug 9617 - Replace YUI menu on catalog pages with Bootstrap Bug 9617 - Replace YUI menu on catalog pages with Bootstrap |
||
|
Description
Owen Leonard
2013-02-15 14:47:17 UTC
Created attachment 15561 [details] [review] Bug 9617 - Replace YUI menu on catalog pages with Bootstrap This patch converts the toolbar include file used by catalog detail pages (detail.pl, MARCdetail.pl, etc.) replacing YUI button and menu code with Bootstrap. Minor change to staff client CSS fixes issue with language footer. Minor change to doc-head-close.inc corrects error in logic for handling cart and lists js discovered in testing. To test, view any page which uses cat-toolbar.inc. Buttons and menus should look correct and work correctly. Functions to test include: New record New item New subscription New child record Edit record Edit items Edit items in a batch Delete items in a batch Attach item Edit as new (duplicate) Replace record via Z39.50 Delete record Delete all items Save (various formats) Add to cart Add to list Print Place hold (including with search-to-hold active). Testing should be done by users with varying permissions including with and without: CAN_user_serials_create_subscription CAN_user_editcatalogue_edit_catalogue CAN_user_editcatalogue_edit_items CAN_user_tools_items_batchmod CAN_user_tools_items_batchdel Created attachment 15591 [details] [review] [SIGNED-OFF] Bug 9617 - Replace YUI menu on catalog pages with Bootstrap This patch converts the toolbar include file used by catalog detail pages (detail.pl, MARCdetail.pl, etc.) replacing YUI button and menu code with Bootstrap. Minor change to staff client CSS fixes issue with language footer. Minor change to doc-head-close.inc corrects error in logic for handling cart and lists js discovered in testing. To test, view any page which uses cat-toolbar.inc. Buttons and menus should look correct and work correctly. Functions to test include: New record New item New subscription New child record Edit record Edit items Edit items in a batch Delete items in a batch Attach item Edit as new (duplicate) Replace record via Z39.50 Delete record Delete all items Save (various formats) Add to cart Add to list Print Place hold (including with search-to-hold active). Testing should be done by users with varying permissions including with and without: CAN_user_serials_create_subscription CAN_user_editcatalogue_edit_catalogue CAN_user_editcatalogue_edit_items CAN_user_tools_items_batchmod CAN_user_tools_items_batchdel Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: All buttons tested. Works as described. No Errors. Looks good. QA comment: Woow, great patch. cat-toolcar.inc burned eyes so much! :) All works perfectly, I didn't find any regression. I think that a form element with an id='f' and name='f' is not really a good idea since it is an include file, but it was already present before this patch. However, one remark (because I don't know if it is wanted): the div#toolbar has a margin-top: 10px; added by the .btn-toolbar. So the toolbar is 10px under its previous position. Marked as Passed QA. Created attachment 15773 [details] [review] Bug 9617 - Replace YUI menu on catalog pages with Bootstrap This patch converts the toolbar include file used by catalog detail pages (detail.pl, MARCdetail.pl, etc.) replacing YUI button and menu code with Bootstrap. Minor change to staff client CSS fixes issue with language footer. Minor change to doc-head-close.inc corrects error in logic for handling cart and lists js discovered in testing. To test, view any page which uses cat-toolbar.inc. Buttons and menus should look correct and work correctly. Functions to test include: New record New item New subscription New child record Edit record Edit items Edit items in a batch Delete items in a batch Attach item Edit as new (duplicate) Replace record via Z39.50 Delete record Delete all items Save (various formats) Add to cart Add to list Print Place hold (including with search-to-hold active). Testing should be done by users with varying permissions including with and without: CAN_user_serials_create_subscription CAN_user_editcatalogue_edit_catalogue CAN_user_editcatalogue_edit_items CAN_user_tools_items_batchmod CAN_user_tools_items_batchdel Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: All buttons tested. Works as described. No Errors. Looks good. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> (In reply to comment #3) > However, one remark (because I don't know if it is wanted): the div#toolbar > has a margin-top: 10px; added by the .btn-toolbar. So the toolbar is 10px > under its previous position. Owen, If is not wanted, we can redefine the margin-top property for div#toolbar ( margin-top: 0;). Could be done in a followup. This patch has been pushed to master. |