Description
Kyle M Hall (khall)
2013-02-15 15:23:15 UTC
Created attachment 15364 [details] [review] Bug 9618 - Add support for intranetuserjs to labels/spinelabel-print.pl Created attachment 15365 [details] [review] Bug 9618 - Add support for intranetuserjs to labels/spinelabel-print.pl Created attachment 15379 [details] [review] Bug 9618 - Add support for intranetuserjs to labels/spinelabel-print.pl This patch has no commit message, thus no description of its purpose and no test plan. Created attachment 15722 [details] [review] Bug 9618 - Add support for intranetuserjs to labels/spinelabel-print.pl For some reason, spinelabel-print.pl is is including intranetuserjs. This pref would be useful for making certain customizations to spine labels. Test Plan: 1) Apply patch 2) Put something in the syspref intranetuserjs 3) Load up labels/spinelabel-print.pl 4) View the page source and verify the code you entered in intranetuserjs is there. Created attachment 16306 [details] [review] Bug 9618 - Add support for intranetuserjs to labels/spinelabel-print.pl The template for printing a single spine label is a stripped-down version of a standard Koha template, but it should include intranetuserjs and IntranetUserCSS so that libraries can make local customizations. This patch updates the page's DOCTYPE to HTML5 and adds the missing markup for including those preferences. Also added is jQuery, since there's a good chance local customizations are using jQuery. To test, make sure there is something in your intranetuserjs and IntranetUserCSS system preferences. Visit /cgi-bin/koha/labels/spinelabel-home.pl and submit a barcode. View source on the spine label output page and confirm that your custom js and css were included correctly. Created attachment 18416 [details] [review] Bug 9618: Followup Add support for intranetuserjs to labels/spinelabel-print.pl the jQuery lib is useful only if js code is filled into the intranetuserjs pref. I think the jQuery lib should only be include if user had defined js code. Owen, could you confirm that please? > I think the jQuery lib should only be include if user had defined js code.
That makes sense to me.
Created attachment 20685 [details] [review] Signed Off: 16306: Bug 9618 - Add support for intranetuserjs to labels/spinelabel-print.pl Created attachment 20686 [details] [review] Signed Off: 18416: Bug 9618: Followup Add support for intranetuserjs to labels/spinelabel-print.pl Created attachment 20930 [details] [review] [PASSED QA] Bug 9618 - Add support for intranetuserjs to labels/spinelabel-print.pl The template for printing a single spine label is a stripped-down version of a standard Koha template, but it should include intranetuserjs and IntranetUserCSS so that libraries can make local customizations. This patch updates the page's DOCTYPE to HTML5 and adds the missing markup for including those preferences. Also added is jQuery, since there's a good chance local customizations are using jQuery. To test, make sure there is something in your intranetuserjs and IntranetUserCSS system preferences. Visit /cgi-bin/koha/labels/spinelabel-home.pl and submit a barcode. View source on the spine label output page and confirm that your custom js and css were included correctly. Signed-off-by: Campbell Reid-Tait <campbellreidtait@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Template only change, works nicely. Created attachment 20931 [details] [review] [PASSED QA] Bug 9618: Followup Add support for intranetuserjs to labels/spinelabel-print.pl the jQuery lib is useful only if js code is filled into the intranetuserjs pref. Signed-off-by: Campbell Reid-Tait <campbellreidtait@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> To test: - Use Quick spine label creator - Make sure you have Javascript in your intranetuserjs system preference - Validate Javascript effect on screen or check source code to make sure your code is visible there. Pushed to master. Thanks, Owen! This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Owen! |