Summary: | Replace YUI menu on lists pages with Bootstrap | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | bgkriegel |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/virtualshelves/shelves.pl | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 9420 - Work on Bootstrap for Koha: Lists toolbar
Bug 9621 - Replace YUI menu on lists pages with Bootstrap [SIGNED-OFF] Bug 9621 - Replace YUI menu on lists pages with Bootstrap [PASSED QA] Bug 9621 - Replace YUI menu on lists pages with Bootstrap |
Description
Owen Leonard
2013-02-15 15:49:11 UTC
Created attachment 15371 [details] [review] Bug 9420 - Work on Bootstrap for Koha: Lists toolbar This patch converts the toolbar include file used by lists pages to Bootstrap, replacing YUI button and menu code with Bootstrap markup. To test, view any page in virtualshelves/ which uses virtualshelves-toolbar.inc (shelves.pl). Buttons and menus should look correct and work correctly when viewing own lists, others' lists, etc. Created attachment 15372 [details] [review] Bug 9621 - Replace YUI menu on lists pages with Bootstrap This patch converts the toolbar include file used by lists pages to Bootstrap, replacing YUI button and menu code with Bootstrap markup. To test, view any page in virtualshelves/ which uses virtualshelves-toolbar.inc (shelves.pl). Buttons and menus should look correct and work correctly when viewing own lists, others' lists, etc. Revised: corrected bug number and title Created attachment 15375 [details] [review] [SIGNED-OFF] Bug 9621 - Replace YUI menu on lists pages with Bootstrap This patch converts the toolbar include file used by lists pages to Bootstrap, replacing YUI button and menu code with Bootstrap markup. To test, view any page in virtualshelves/ which uses virtualshelves-toolbar.inc (shelves.pl). Buttons and menus should look correct and work correctly when viewing own lists, others' lists, etc. Revised: corrected bug number and title Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No error. Looks very good. As well as Bug 9616 the result is 10px downward from the original. Created attachment 15447 [details] [review] [PASSED QA] Bug 9621 - Replace YUI menu on lists pages with Bootstrap This patch converts the toolbar include file used by lists pages to Bootstrap, replacing YUI button and menu code with Bootstrap markup. To test, view any page in virtualshelves/ which uses virtualshelves-toolbar.inc (shelves.pl). Buttons and menus should look correct and work correctly when viewing own lists, others' lists, etc. Revised: corrected bug number and title Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No error. Looks very good. As well as Bug 9616 the result is 10px downward from the original. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, on problems found. This patch has been pushed to master. |