| Summary: | Replace YUI button on reports dictionary page with Bootstrap | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | bgkriegel |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | /cgi-bin/koha/reports/dictionary.pl?phase=View Dictionary | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 9624 - Replace YUI button on reports dictionary page with Bootstrap
[SIGNED-OFF] Bug 9624 - Replace YUI button on reports dictionary page with Bootstrap [PASSED QA] Bug 9624 - Replace YUI button on reports dictionary page with Bootstrap |
||
|
Description
Owen Leonard
2013-02-15 16:34:45 UTC
Created attachment 15376 [details] [review] Bug 9624 - Replace YUI button on reports dictionary page with Bootstrap This patch removes the toolbar include file used by the reports dictionary and embeds the toolbar markup directly in the main template since it's the only instance where it is used. Toolbar is converted to use Bootstrap, replacing YUI button code with Bootstrap markup. To test, view the reports dictionary and confirm that the "New definition" button looks correct and works correctly. Created attachment 15383 [details] [review] [SIGNED-OFF] Bug 9624 - Replace YUI button on reports dictionary page with Bootstrap This patch removes the toolbar include file used by the reports dictionary and embeds the toolbar markup directly in the main template since it's the only instance where it is used. Toolbar is converted to use Bootstrap, replacing YUI button code with Bootstrap markup. To test, view the reports dictionary and confirm that the "New definition" button looks correct and works correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. Created attachment 15445 [details] [review] [PASSED QA] Bug 9624 - Replace YUI button on reports dictionary page with Bootstrap This patch removes the toolbar include file used by the reports dictionary and embeds the toolbar markup directly in the main template since it's the only instance where it is used. Toolbar is converted to use Bootstrap, replacing YUI button code with Bootstrap markup. To test, view the reports dictionary and confirm that the "New definition" button looks correct and works correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, no problems found. This patch has been pushed to master. |