| Summary: | Replace YUI buttons and menus on reports pages with Bootstrap | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> | 
| Component: | Templates | Assignee: | Owen Leonard <oleonard> | 
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> | 
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | bgkriegel | 
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | /cgi-bin/koha/reports/guided_reports.pl | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | --- | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Attachments: | 
              Bug 9625 - Replace YUI buttons and menus on reports pages with Bootstrap
               [SIGNED-OFF] Bug 9625 - Replace YUI buttons and menus on reports pages with Bootstrap [PASSED QA] Bug 9625 - Replace YUI buttons and menus on reports pages with Bootstrap  | 
      ||
| 
 
        
          Description
        
        
          Owen Leonard
        
        
        
        
          2013-02-15 16:41:10 UTC
        
       
    Created attachment 15378 [details] [review] Bug 9625 - Replace YUI buttons and menus on reports pages with Bootstrap This patch converts the toolbar include file used by guided/SQL report pages to Bootstrap, replacing YUI button and menu code with Bootstrap markup. To test, view any page in reports/ which uses reports-toolbar.inc (Saved reports, Guided reports, SQL reports). Buttons and menus should look correct and work correctly. Created attachment 15385 [details] [review] [SIGNED-OFF] Bug 9625 - Replace YUI buttons and menus on reports pages with Bootstrap This patch converts the toolbar include file used by guided/SQL report pages to Bootstrap, replacing YUI button and menu code with Bootstrap markup. To test, view any page in reports/ which uses reports-toolbar.inc (Saved reports, Guided reports, SQL reports). Buttons and menus should look correct and work correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works as described. No errors. Created attachment 15469 [details] [review] [PASSED QA] Bug 9625 - Replace YUI buttons and menus on reports pages with Bootstrap This patch converts the toolbar include file used by guided/SQL report pages to Bootstrap, replacing YUI button and menu code with Bootstrap markup. To test, view any page in reports/ which uses reports-toolbar.inc (Saved reports, Guided reports, SQL reports). Buttons and menus should look correct and work correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works as described. No errors. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, logic is correct. Toolbar differes, depending on the action: show report, list of reports, edit report. Is there a reason for the 'xx' in this line: +[% IF ( showsql || execute || editsql || save_successful ) %]xx If not -- and I don't think there is -- I will remove it prior to pushing. (In reply to comment #4) > Is there a reason for the 'xx' in this line: > +[% IF ( showsql || execute || editsql || save_successful ) %]xx > > If not -- and I don't think there is -- I will remove it prior to pushing. Thank you, you are correct. This patch has been pushed to master.  |