Bug 9625

Summary: Replace YUI buttons and menus on reports pages with Bootstrap
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: enhancement    
Priority: P5 - low CC: bgkriegel
Version: Main   
Hardware: All   
OS: All   
URL: /cgi-bin/koha/reports/guided_reports.pl
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 9625 - Replace YUI buttons and menus on reports pages with Bootstrap
[SIGNED-OFF] Bug 9625 - Replace YUI buttons and menus on reports pages with Bootstrap
[PASSED QA] Bug 9625 - Replace YUI buttons and menus on reports pages with Bootstrap

Description Owen Leonard 2013-02-15 16:41:10 UTC
The toolbar include file used by some reports pages uses YUI to generate buttons and menus. It should use Bootstrap instead.
Comment 1 Owen Leonard 2013-02-15 16:45:53 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-02-15 17:13:15 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-02-17 14:38:31 UTC
Created attachment 15469 [details] [review]
[PASSED QA] Bug 9625 - Replace YUI buttons and menus on reports pages with Bootstrap

This patch converts the toolbar include file used by guided/SQL report
pages to Bootstrap, replacing YUI button and menu code with Bootstrap
markup.

To test, view any page in reports/ which uses reports-toolbar.inc
(Saved reports, Guided reports, SQL reports). Buttons and menus should
look correct and work correctly.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Works as described. No errors.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely, logic is correct. Toolbar differes, depending
on the action: show report, list of reports, edit report.
Comment 4 Jared Camins-Esakov 2013-02-18 13:13:47 UTC
Is there a reason for the 'xx' in this line:
+[% IF ( showsql || execute || editsql || save_successful ) %]xx

If not -- and I don't think there is -- I will remove it prior to pushing.
Comment 5 Owen Leonard 2013-02-19 14:23:17 UTC
(In reply to comment #4)
> Is there a reason for the 'xx' in this line:
> +[% IF ( showsql || execute || editsql || save_successful ) %]xx
> 
> If not -- and I don't think there is -- I will remove it prior to pushing.

Thank you, you are correct.
Comment 6 Jared Camins-Esakov 2013-02-20 13:27:41 UTC
This patch has been pushed to master.