Summary: | Replace YUI buttons on labels pages with Bootstrap | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | bgkriegel |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/labels/label-home.pl | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 9636 - Replace YUI buttons on labels pages with Bootstrap
[SIGNED-OFF] Bug 9636 - Replace YUI buttons on labels pages with Bootstrap [PASSED QA] Bug 9636 - Replace YUI buttons on labels pages with Bootstrap |
Description
Owen Leonard
2013-02-15 19:29:48 UTC
Created attachment 15398 [details] [review] Bug 9636 - Replace YUI buttons on labels pages with Bootstrap This patch converts the toolbar include file used by the label manager to Bootstrap, replacing YUI button and menu code with Bootstrap markup. This patch converts the previous menu buttons to plain buttons, removing the redundant links to the manage pages, which are in the left-hand sidebar. This keeps toolbar buttons within the general category of "action" (as opposed to "view"). This patch also removes an unused include file, labels-new-toolbar.inc To test, view the labels home page and any of the label manage pages (layouts, templates, profiles, batches). Buttons should look correct and work correctly. Created attachment 15406 [details] [review] [SIGNED-OFF] Bug 9636 - Replace YUI buttons on labels pages with Bootstrap This patch converts the toolbar include file used by the label manager to Bootstrap, replacing YUI button and menu code with Bootstrap markup. This patch converts the previous menu buttons to plain buttons, removing the redundant links to the manage pages, which are in the left-hand sidebar. This keeps toolbar buttons within the general category of "action" (as opposed to "view"). This patch also removes an unused include file, labels-new-toolbar.inc To test, view the labels home page and any of the label manage pages (layouts, templates, profiles, batches). Buttons should look correct and work correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. Nicole is not going to be happy, images in Label creator section of manual needs to change :) Created attachment 15456 [details] [review] [PASSED QA] Bug 9636 - Replace YUI buttons on labels pages with Bootstrap This patch converts the toolbar include file used by the label manager to Bootstrap, replacing YUI button and menu code with Bootstrap markup. This patch converts the previous menu buttons to plain buttons, removing the redundant links to the manage pages, which are in the left-hand sidebar. This keeps toolbar buttons within the general category of "action" (as opposed to "view"). This patch also removes an unused include file, labels-new-toolbar.inc To test, view the labels home page and any of the label manage pages (layouts, templates, profiles, batches). Buttons should look correct and work correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. Nicole is not going to be happy, images in Label creator section of manual needs to change :) Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, I was wondering if we should have the plus icon on those buttons like we have on the other 'New' buttons. I like the changes to the menu structure. My only question is, why the buttons don't have the plus icons like we have it on the other 'new' buttons. No reason not to pass QA on this improvement tho :) This patch has been pushed to master. |