Bug 9645

Summary: Replace YUI buttons on the quotes management page with Bootstrap
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: enhancement    
Priority: P5 - low CC: bgkriegel
Version: Main   
Hardware: All   
OS: All   
URL: /cgi-bin/koha/tools/quotes.pl
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 9645 - Replace YUI buttons on the quotes management page with Bootstrap
[SIGNED-OFF] Bug 9645 - Replace YUI buttons on the quotes management page with Bootstrap
[PASSED QA] Bug 9645 - Replace YUI buttons on the quotes management page with Bootstrap

Description Owen Leonard 2013-02-15 20:39:21 UTC
The toolbar buttons on the quotes management page are generated by YUI. They should use Bootstrap instead.
Comment 1 Owen Leonard 2013-02-15 20:44:58 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-02-15 21:43:57 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-02-17 15:01:10 UTC
Created attachment 15472 [details] [review]
[PASSED QA] Bug 9645 - Replace YUI buttons on the quotes management page with Bootstrap

This patch converts the toolbar include file used by the quotes editor
to Bootstrap, replacing YUI button and menu code with Bootstrap markup.

To test, view any page in the quotes editor. Buttons and menus should
look correct and work correctly. Test save, delete, and upload buttons
on the summary page, and save and delete buttons on the upload page.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: All buttons work. Tested add, delete and upload.
You are using icon-remove and not icon-remove-circle,
which I prefer but is different of Bug 9627.
Question: "Import quotes" takes you to "Quotes uploader",
would not it be more consistent to use "Upload quotes" or
"Quotes importer"?

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely, no problems found.
I think the difference to 9627 is, that this really deletes
quotes, while the icon-remove-circle is used for closing subscriptions.
Closed subscriptions remain in the system, it's just a way to indicate
that there will be no new issues. There is a separate option to really
delete subscriptions.
Comment 4 Jared Camins-Esakov 2013-02-18 14:10:06 UTC
This patch has been pushed to master.