Summary: | Replace YUI buttons on the quotes management page with Bootstrap | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | bgkriegel |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/tools/quotes.pl | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 9645 - Replace YUI buttons on the quotes management page with Bootstrap
[SIGNED-OFF] Bug 9645 - Replace YUI buttons on the quotes management page with Bootstrap [PASSED QA] Bug 9645 - Replace YUI buttons on the quotes management page with Bootstrap |
Description
Owen Leonard
2013-02-15 20:39:21 UTC
Created attachment 15414 [details] [review] Bug 9645 - Replace YUI buttons on the quotes management page with Bootstrap This patch converts the toolbar include file used by the quotes editor to Bootstrap, replacing YUI button and menu code with Bootstrap markup. To test, view any page in the quotes editor. Buttons and menus should look correct and work correctly. Test save, delete, and upload buttons on the summary page, and save and delete buttons on the upload page. Created attachment 15419 [details] [review] [SIGNED-OFF] Bug 9645 - Replace YUI buttons on the quotes management page with Bootstrap This patch converts the toolbar include file used by the quotes editor to Bootstrap, replacing YUI button and menu code with Bootstrap markup. To test, view any page in the quotes editor. Buttons and menus should look correct and work correctly. Test save, delete, and upload buttons on the summary page, and save and delete buttons on the upload page. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: All buttons work. Tested add, delete and upload. You are using icon-remove and not icon-remove-circle, which I prefer but is different of Bug 9627. Question: "Import quotes" takes you to "Quotes uploader", would not it be more consistent to use "Upload quotes" or "Quotes importer"? Created attachment 15472 [details] [review] [PASSED QA] Bug 9645 - Replace YUI buttons on the quotes management page with Bootstrap This patch converts the toolbar include file used by the quotes editor to Bootstrap, replacing YUI button and menu code with Bootstrap markup. To test, view any page in the quotes editor. Buttons and menus should look correct and work correctly. Test save, delete, and upload buttons on the summary page, and save and delete buttons on the upload page. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: All buttons work. Tested add, delete and upload. You are using icon-remove and not icon-remove-circle, which I prefer but is different of Bug 9627. Question: "Import quotes" takes you to "Quotes uploader", would not it be more consistent to use "Upload quotes" or "Quotes importer"? Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, no problems found. I think the difference to 9627 is, that this really deletes quotes, while the icon-remove-circle is used for closing subscriptions. Closed subscriptions remain in the system, it's just a way to indicate that there will be no new issues. There is a separate option to really delete subscriptions. This patch has been pushed to master. |