Bug 9649

Summary: Replace YUI buttons on cataloging home page with Bootstrap
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: enhancement    
Priority: P5 - low CC: bgkriegel, katrin.fischer
Version: Main   
Hardware: All   
OS: All   
URL: /cgi-bin/koha/cataloguing/addbooks.pl
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 9649 - Replace YUI buttons on cataloging home page with Bootstrap
[SIGNED-OFF] Bug 9649 - Replace YUI buttons on cataloging home page with Bootstrap
[PASSED QA] Bug 9649 - Replace YUI buttons on cataloging home page with Bootstrap

Description Owen Leonard 2013-02-16 21:18:47 UTC
The toolbar buttons on the cataloging pages (addbooks.pl and addbiblio.pl) are constructed using YUI. They should use Bootstrap instead.
Comment 1 Owen Leonard 2013-02-19 20:49:20 UTC
I thought addbooks.pl and addbiblio.pl shared a toolbar include. They do not, so I'm changing the scope of this bug to cover only addbooks.pl.
Comment 2 Owen Leonard 2013-02-19 21:26:44 UTC Comment hidden (obsolete)
Comment 3 Bernardo Gonzalez Kriegel 2013-02-21 17:48:49 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2013-03-04 07:09:42 UTC
Created attachment 15835 [details] [review]
[PASSED QA] Bug 9649 - Replace YUI buttons on cataloging home page with Bootstrap

This patch converts the buttons on the cataloging home page to
Bootstrap, replacing the YUI button and menu code with Bootstrap markup.

This patch moves the functionality of cataloging-toolbar.inc
into addbooks.tt since it is the only place where the include
was used. cataloging-toolbar.inc is removed.

To test, view the cataloging home page. Buttons and menus should look
correct and work correctly.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Buttons look and work well. No errors.

Please sign Bug 3549

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely, no problems found.
Comment 5 Jared Camins-Esakov 2013-03-07 15:29:04 UTC
This patch has been pushed to master.