Bug 9662

Summary: z3950_search.pl ISSN search field not passed to Z3950Search
Product: Koha Reporter: Dobrica Pavlinusic <dpavlin>
Component: CatalogingAssignee: Dobrica Pavlinusic <dpavlin>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: major    
Priority: P5 - low CC: chris, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 9662 - ISSN search field not passed to Z3950Search
Bug 9662 - ISSN search field not passed to Z3950Search
Bug 9662: Followup for acquisition

Description Dobrica Pavlinusic 2013-02-19 14:55:33 UTC

    
Comment 1 Dobrica Pavlinusic 2013-02-19 15:00:52 UTC Comment hidden (obsolete)
Comment 2 Marcel de Rooy 2013-02-20 12:50:53 UTC
Created attachment 15565 [details] [review]
Bug 9662 - ISSN search field not passed to Z3950Search

Seems like simple omission when passing $pars hash to
Z3950Search function.

Test scenario:

1. select any Z39.50 search form and enter valid ISSN
2. verify that you don't get any results from remote servers
3. apply this patch and re-check that results are now availble
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 3 Marcel de Rooy 2013-02-20 12:50:55 UTC
Created attachment 15566 [details] [review]
Bug 9662: Followup for acquisition

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Trivial change corresponding with Dobrica's patch at cataloging side.
Comment 4 Marcel de Rooy 2013-02-20 13:00:34 UTC
QA Comment:
Two easy one line patches making lots of people happy searching on ISSN :)
Looks good to me. (Probably forgot to add this field myself..)
Have been so bold to add the second patch myself instead of harassing Dobrica..

Passed QA

Dobrica: If you read this before Jared does, please feel free to check..
Comment 5 Jared Camins-Esakov 2013-02-20 14:56:27 UTC
This patch has been pushed to master.
Comment 6 Chris Cormack 2013-02-21 05:51:42 UTC
Does not apply on 3.10.x please submit a patch for it if you wish it.
Comment 7 Marcel de Rooy 2013-02-21 07:37:43 UTC
(In reply to comment #6)
> Does not apply on 3.10.x please submit a patch for it if you wish it.

The patches are only relevant for master, not for 3.10.x or lower..