Summary: | Inventory scrolling to top with every click | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Tools | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | minor | ||
Priority: | P5 - low | CC: | aleisha, bugzilla, ian, mathsabypro, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 9667 - Inventory scrolling to top with every click
Signed patch Bug 9667 - Inventory scrolling to top with every click |
Description
Nicole C. Engard
2013-02-19 18:42:42 UTC
Workaround that works in 3.6: go back one page in browser to return to original position on inventory list. Still happens in current master. Created attachment 29676 [details] [review] Bug 9667 - Inventory scrolling to top with every click An "onclick" attribute on inventory results links causes the page to scroll to the top each time. This patch updates the click handling to use a progressive-enhancement method. Unrelated changes: I added use of the Branches T:T plugin to output library name instead of branchcode, and put a check around call number to prevent output of empty [] in results. To test, use the inventory tool to check a batch of items. On the results page: - Confirm that branch name is shown instead of code. - Confirm that no [] shows for items without call numbers - Confirm that clicking a title opens a pop-up window showing details for that title. - Confirm that clicking a title opens a pop-up window whether you're on the first page of results or any subsequent page. Inventory is still scrolling to top after clicking on the link to an item and branch code is still being shown rather than branch name, so failing QA. However the pop-up window does open showing details when clicked on on any page, and [] shows for items without call numbers, so these work as they should. Thanks for testing Aleshia, but I'm not sure why it's not working for you. Everything works for me. Perhaps someone else could take a look? Created attachment 30052 [details] [review] Signed patch All good. Created attachment 30082 [details] [review] Bug 9667 - Inventory scrolling to top with every click An "onclick" attribute on inventory results links causes the page to scroll to the top each time. This patch updates the click handling to use a progressive-enhancement method. Unrelated changes: I added use of the Branches T:T plugin to output library name instead of branchcode, and put a check around call number to prevent output of empty [] in results. To test, use the inventory tool to check a batch of items. On the results page: - Confirm that branch name is shown instead of code. - Confirm that no [] shows for items without call numbers - Confirm that clicking a title opens a pop-up window showing details for that title. - Confirm that clicking a title opens a pop-up window whether you're on the first page of results or any subsequent page. Signed-off-by: Ian Beardslee <ian@catalyst.net.nz> Tested in Firefox and Chromium. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Patch pushed to master. Thanks Owen! |