Summary: | fines.pl cronjob help lists wrong values for finesmode syspref | ||
---|---|---|---|
Product: | Koha | Reporter: | Jared Camins-Esakov <jcamins> |
Component: | Command-line Utilities | Assignee: | Aaron Wells <aaronw> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | trivial | ||
Priority: | P5 - low | CC: | aaronw, dcook, liz |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | String patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
A patch to correct the fines.pl help text
Bug 9671: Make fines.pl help text more accurate Bug 9671: Make fines.pl help text more accurate [PASSED QA] Bug 9671: Make fines.pl help text more accurate |
Description
Jared Camins-Esakov
2013-02-20 13:15:45 UTC
Created attachment 16843 [details] [review] A patch to correct the fines.pl help text Adding a patch to correct the fines.pl help text to match the options for finesMode (In reply to comment #1) > Created attachment 16843 [details] [review] [review] > A patch to correct the fines.pl help text > > Adding a patch to correct the fines.pl help text to match the options for > finesMode Personally, I'd rather sign off on a patch that includes the actual values ("Calculate (but only for mailing to the admin)", "Calculate and charge", and "Don't calculate") for the system preference along with an explanation rather than just the explanation. This patch lacks a commit message which describes the problem, describes the solution, and shows how to test. Created attachment 17329 [details] [review] Bug 9671: Make fines.pl help text more accurate To test: run kohaclone/misc/cronjobs/fines.pl --help and note the help text. It should match the settings in System Preferences. Merely fixing up the commit message. Created attachment 17403 [details] [review] Bug 9671: Make fines.pl help text more accurate To test: run kohaclone/misc/cronjobs/fines.pl --help and note the help text. It should match the settings in System Preferences. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Just a note on this - the longer descriptions only make sense if you are using the English templates. The shorter versions would have worked for me too ;) Created attachment 17571 [details] [review] [PASSED QA] Bug 9671: Make fines.pl help text more accurate To test: run kohaclone/misc/cronjobs/fines.pl --help and note the help text. It should match the settings in System Preferences. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Documentation change, passes all tests. This patch has been pushed to master and 3.12.x. |