| Summary: | Replace YUI buttons on authorities home page with Bootstrap | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | bgkriegel |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 9675 - Replace YUI buttons on authorities home page with Bootstrap
Bug 9675 - Replace YUI buttons on authorities home page with Bootstrap [SIGNED-OFF] Bug 9675 - Replace YUI buttons on authorities home page with Bootstrap [PASSED QA] Bug 9675 - Replace YUI buttons on authorities home page with Bootstrap |
||
|
Description
Owen Leonard
2013-02-20 19:36:59 UTC
Created attachment 15573 [details] [review] Bug 9675 - Replace YUI buttons on authorities home page with Bootstrap This patch converts the toolbar include file used by the authorities home page and authority view page (authorities-home.pl and authorities/detail.pl) replacing YUI button and menu code with Bootstrap. To test: - View the authorities home page and confirm that the "New authority" button looks correct and works correctly. - Search for an existing authority and click the "Details" link to view. "Edit," "Delete," "Save," and "New authority" buttons should look correct and work correctly. The "Delete" button should only appear for authorities which are unused. Ooops. Does not apply. Seems that your authorities-toolbar.inc is not the same as master's. Created attachment 15598 [details] [review] Bug 9675 - Replace YUI buttons on authorities home page with Bootstrap This patch converts the toolbar include file used by the authorities home page and authority view page (authorities-home.pl and authorities/detail.pl) replacing YUI button and menu code with Bootstrap. To test: - View the authorities home page and confirm that the "New authority" button looks correct and works correctly. - Search for an existing authority and click the "Details" link to view. "Edit," "Delete," "Save," and "New authority" buttons should look correct and work correctly. The "Delete" button should only appear for authorities which are unused. Sorry about that -- I missed a commit in an interactive rebase. Please try again. Created attachment 15599 [details] [review] [SIGNED-OFF] Bug 9675 - Replace YUI buttons on authorities home page with Bootstrap This patch converts the toolbar include file used by the authorities home page and authority view page (authorities-home.pl and authorities/detail.pl) replacing YUI button and menu code with Bootstrap. To test: - View the authorities home page and confirm that the "New authority" button looks correct and works correctly. - Search for an existing authority and click the "Details" link to view. "Edit," "Delete," "Save," and "New authority" buttons should look correct and work correctly. The "Delete" button should only appear for authorities which are unused. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Now it works. New and all operations on existing auth works. No errors. Created attachment 15828 [details] [review] [PASSED QA] Bug 9675 - Replace YUI buttons on authorities home page with Bootstrap This patch converts the toolbar include file used by the authorities home page and authority view page (authorities-home.pl and authorities/detail.pl) replacing YUI button and menu code with Bootstrap. To test: - View the authorities home page and confirm that the "New authority" button looks correct and works correctly. - Search for an existing authority and click the "Details" link to view. "Edit," "Delete," "Save," and "New authority" buttons should look correct and work correctly. The "Delete" button should only appear for authorities which are unused. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Now it works. New and all operations on existing auth works. No errors. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, no problems found. I was a bit surprised that the "New" pull down is last on an authority detail page as it's normally the first on other pages. This patch has been pushed to master. |