Summary: | can't place hold from cart in CCSR | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | major | ||
Priority: | P5 - low | CC: | chris |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 9679 - can't place hold from cart in CCSR
[SIGNED-OFF] Bug 9679 - can't place hold from cart in CCSR [PASSED QA] Bug 9679 - can't place hold from cart in CCSR |
Description
Nicole C. Engard
2013-02-20 21:24:35 UTC
Created attachment 18066 [details] [review] Bug 9679 - can't place hold from cart in CCSR When the CCSR theme is enabled, selecting items in the cart and clicking "place hold" triggers a JavaScript error and fails. This patch adds a function missing from the CCSR version of basket.js. To test, apply the patch and clear your browser cache. - Enable the CCSR theme and put items into the OPAC cart. - Open the cart, select one or more items, and click "place hold." The cart should automatically close and the main window should redirect to the holds screen showing your selections. Created attachment 18069 [details] [review] [SIGNED-OFF] Bug 9679 - can't place hold from cart in CCSR When the CCSR theme is enabled, selecting items in the cart and clicking "place hold" triggers a JavaScript error and fails. This patch adds a function missing from the CCSR version of basket.js. To test, apply the patch and clear your browser cache. - Enable the CCSR theme and put items into the OPAC cart. - Open the cart, select one or more items, and click "place hold." The cart should automatically close and the main window should redirect to the holds screen showing your selections. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All test passed http://bugs.koha-community.org/show_bug.cgi?id=9769 Created attachment 18091 [details] [review] [PASSED QA] Bug 9679 - can't place hold from cart in CCSR When the CCSR theme is enabled, selecting items in the cart and clicking "place hold" triggers a JavaScript error and fails. This patch adds a function missing from the CCSR version of basket.js. To test, apply the patch and clear your browser cache. - Enable the CCSR theme and put items into the OPAC cart. - Open the cart, select one or more items, and click "place hold." The cart should automatically close and the main window should redirect to the holds screen showing your selections. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All test passed http://bugs.koha-community.org/show_bug.cgi?id=9769 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Confirmed patch fixes the problem described. All tests and QA script pass, JavaScript only change. No strings involved, save for inclusion in 3.12. This patch has been pushed to master and 3.12.x. Pushed to 3.10.x will be in 3.10.6 |