Summary: | cart aligned right in CCSR | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | ||
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
cart in prog
cart in ccsr Bug 9680 - cart aligned right in CCSR [SIGNED-OFF] Bug 9680 - cart aligned right in CCSR [PASSED QA] Bug 9680 - cart aligned right in CCSR |
Created attachment 15577 [details]
cart in ccsr
see how i have to make the window bigger to see the contents and there is an extra large margin on the left. It should be centered to the window like in PROG
Created attachment 18078 [details] [review] Bug 9680 - cart aligned right in CCSR The CCSR theme sets a min-width of 1000px for windows which are more than 700px wide. This caused the cart popup window to be given a min-width of 1000px, resulting in a broken layout with unnecessary horizontal scrolling. This patch adds a class to the cart template and to other pop-up window templates to ensure that a large min-width is not enforced and to give consistent padding to those pages. To test, set your theme to 'CCSR' and view the following pop-up pages: - The Cart. From the cart, trigger: - The "send" window - The "download" window - From a view of a List's contents trigger: - The "send" window" - The "download" window Each of these pages should look correct with no horizontal scrolling. Created attachment 18079 [details] [review] [SIGNED-OFF] Bug 9680 - cart aligned right in CCSR The CCSR theme sets a min-width of 1000px for windows which are more than 700px wide. This caused the cart popup window to be given a min-width of 1000px, resulting in a broken layout with unnecessary horizontal scrolling. This patch adds a class to the cart template and to other pop-up window templates to ensure that a large min-width is not enforced and to give consistent padding to those pages. To test, set your theme to 'CCSR' and view the following pop-up pages: - The Cart. From the cart, trigger: - The "send" window - The "download" window - From a view of a List's contents trigger: - The "send" window" - The "download" window Each of these pages should look correct with no horizontal scrolling. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All tests pass Created attachment 18088 [details] [review] [PASSED QA] Bug 9680 - cart aligned right in CCSR The CCSR theme sets a min-width of 1000px for windows which are more than 700px wide. This caused the cart popup window to be given a min-width of 1000px, resulting in a broken layout with unnecessary horizontal scrolling. This patch adds a class to the cart template and to other pop-up window templates to ensure that a large min-width is not enforced and to give consistent padding to those pages. To test, set your theme to 'CCSR' and view the following pop-up pages: - The Cart. From the cart, trigger: - The "send" window - The "download" window - From a view of a List's contents trigger: - The "send" window" - The "download" window Each of these pages should look correct with no horizontal scrolling. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All tests pass Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Template and CSS changes only, but no string changes. Save for inclusion in 3.12. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> This patch has been pushed to master and 3.12.x. |
Created attachment 15576 [details] cart in prog When you're using CCSR the cart contents have a big margin on the left that's pushing them off screen. Attached are images of the same cart in both themes - the window is the same size in both.