Summary: | Allow sort baskets by number | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Acquisitions | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | minor | ||
Priority: | P5 - low | CC: | jonathan.druart, m.de.rooy, paul.poulain |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Proposed patch
[SIGNED-OFF] Bug 9685: Allow sort baskets by number Proposed patch (revised) Add robots txt file to deny all bots Bug 9685: Allow sort baskets by number But 9791: Remove single pixel on datatable tables [PASSED QA] Bug 9685: Allow sort baskets by number |
Description
Fridolin Somers
2013-02-21 14:54:46 UTC
Created attachment 15588 [details] [review] Proposed patch See commit message Created attachment 15684 [details] [review] [SIGNED-OFF] Bug 9685: Allow sort baskets by number In acqui/booksellers.pl, first column of baskets tables is "name (#number)". This allows to sort by name but not by numnber. This patch splits acutal first column into 2 columns number and name to allow sorting on number. Test plan: Look at page and use sorting on name and n° columns. Signed-off-by: Owen Leonard <oleonard@myacpl.org> QA comment: The patch submitted by Owen does not apply (fatal: cannot convert from UTF-8utf-8 to UTF-8). Furthermore before this patch, the table is sorted on the basket name by default, after by basketno. We have to keep the same order. Marked as Failed QA. Created attachment 15766 [details] [review] Proposed patch (revised) Added default sort on basket name. Please re-signoff. Patch tested with a sandbox, by Marc Sabin <marc.sabin@sciencespo-grenoble.fr> Created attachment 15926 [details] [review] Add robots txt file to deny all bots Signed-off-by: Marc Sabin <marc.sabin@sciencespo-grenoble.fr> (In reply to comment #6) > Created attachment 15926 [details] [review] [review] > Add robots txt file to deny all bots > > Signed-off-by: Marc Sabin <marc.sabin@sciencespo-grenoble.fr> Looks like a mistake... Comment on attachment 15926 [details] [review] Add robots txt file to deny all bots not the good report. Switch back to Needs Signoff Patch tested with a sandbox, by Marc Sabin <marc.sabin@sciencespo-grenoble.fr> Created attachment 15979 [details] [review] Bug 9685: Allow sort baskets by number In acqui/booksellers.pl, first column of baskets tables is "name (#number)". This allows to sort by name but not by numnber. This patch splits acutal first column into 2 columns number and name to allow sorting on number. Sets default sort on name like existing. Test plan: Look at page and use sorting on name and n° columns. Signed-off-by: Marc Sabin <marc.sabin@sciencespo-grenoble.fr> Created attachment 16029 [details] [review] But 9791: Remove single pixel on datatable tables Test plan: Check on the 5 pages that pixels are disappears after applying this patch. Comment on attachment 16029 [details] [review] But 9791: Remove single pixel on datatable tables Not the good report either... Created attachment 17055 [details] [review] [PASSED QA] Bug 9685: Allow sort baskets by number In acqui/booksellers.pl, first column of baskets tables is "name (#number)". This allows to sort by name but not by numnber. This patch splits acutal first column into 2 columns number and name to allow sorting on number. Sets default sort on name like existing. Test plan: Look at page and use sorting on name and number columns. Signed-off-by: Marc Sabin <marc.sabin@sciencespo-grenoble.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Nice change for better usability. Sorting of both columns works nicely. This patch has been pushed to master. |