| Summary: | Remove YUI styling from buttons on the patron card creator's image manage page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | bgkriegel |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | /cgi-bin/koha/patroncards/image-manage.pl | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 9693 - Remove YUI styling from buttons on the patron card creator's image manage page
pre-patch post-patch upload delete [SIGNED-OFF] Bug 9693 - Remove YUI styling from buttons on the patron card creator's image manage page [PASSED QA] Bug 9693 - Remove YUI styling from buttons on the patron card creator's image manage page |
||
|
Description
Owen Leonard
2013-02-22 13:30:56 UTC
Created attachment 15619 [details] [review] Bug 9693 - Remove YUI styling from buttons on the patron card creator's image manage page Buttons on the patron card creator's image manage page are styled using YUI. They can be classified as submit buttons rather than toolbar buttons, so they should have default submit button styles. This patch removes YUI styling and related JavaScript. Other minor changes: Markup corrections for validity. To test, view the patron card creator's image manage page. "Upload" and "Delete" buttons should look correct and work correctly. Upload and delete operations should function normally. Created attachment 15630 [details]
pre-patch
Created attachment 15631 [details]
post-patch
Created attachment 15632 [details]
upload
Created attachment 15633 [details]
delete
Hi, 1) Added pre and post screen. Is that (post) the final look? 2) When you upload or delete a file, a box indicating the action appears, and a few seconds later disappears. With patch applied, they do not disappear any more. (In reply to comment #6) > 1) Added pre and post screen. Is that (post) the final look? Yes: A submit button with default styling and a plain "cancel" link, consistent with other "save/cancel" pairs throughout Koha. > 2) When you upload or delete a file, a box indicating the action appears, > and a few seconds later disappears. With patch applied, they do not > disappear any more. This is a change peripheral to the patch, so I should have mentioned it: This kind of interface behavior is non-standard and I removed it rather than update it along with other JavaScript changes. The disappearing effect isn't required for functionality, leaving messages visible could be helpful to users who are not watching the screen constantly during these operations. Created attachment 15637 [details] [review] [SIGNED-OFF] Bug 9693 - Remove YUI styling from buttons on the patron card creator's image manage page Buttons on the patron card creator's image manage page are styled using YUI. They can be classified as submit buttons rather than toolbar buttons, so they should have default submit button styles. This patch removes YUI styling and related JavaScript. Other minor changes: Markup corrections for validity. To test, view the patron card creator's image manage page. "Upload" and "Delete" buttons should look correct and work correctly. Upload and delete operations should function normally. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. Questions answered in comments. Created attachment 15829 [details] [review] [PASSED QA] Bug 9693 - Remove YUI styling from buttons on the patron card creator's image manage page Buttons on the patron card creator's image manage page are styled using YUI. They can be classified as submit buttons rather than toolbar buttons, so they should have default submit button styles. This patch removes YUI styling and related JavaScript. Other minor changes: Markup corrections for validity. To test, view the patron card creator's image manage page. "Upload" and "Delete" buttons should look correct and work correctly. Upload and delete operations should function normally. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. Questions answered in comments. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely and is more consistent. This patch has been pushed to master. |