| Summary: | Remove YUI styling from buttons on the patron card creator manage pages | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | bgkriegel |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | /cgi-bin/koha/patroncards/manage.pl?card_element= | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 9694 - Remove YUI styling from buttons on the patron card creator manage pages
Bug 9694 - Remove YUI styling from buttons on the patron card creator manage pages [SIGNED-OFF] Bug 9694 - Remove YUI styling from buttons on the patron card creator manage pages [PASSED QA] Bug 9694 - Remove YUI styling from buttons on the patron card creator manage pages |
||
|
Description
Owen Leonard
2013-02-22 14:24:20 UTC
Created attachment 15620 [details] [review] Bug 9694 - Remove YUI styling from buttons on the patron card creator manage pages Buttons on the patron card creator's manage pages (manage templates, manage profiles, etc) are styled using YUI. They can be classified as submit buttons rather than toolbar buttons, so they should have default submit button styles. This patch removes YUI styling and related JavaScript. Other minor changes: Escaping strings in JavaScript for translation. To test, view the patron card creator's manage page for layouts, templates, profiles, and batches. "Edit," "Delete," and "Export" buttons should look correct and work correctly. Created attachment 15624 [details] [review] Bug 9694 - Remove YUI styling from buttons on the patron card creator manage pages Buttons on the patron card creator's manage pages (manage templates, manage profiles, etc) are styled using YUI. They can be classified as submit buttons rather than toolbar buttons, so they should have default submit button styles. This patch removes YUI styling and related JavaScript. Other minor changes: Escaping strings in JavaScript for translation. To test, view the patron card creator's manage page for layouts, templates, profiles, and batches. "Edit," "Delete," and "Export" buttons should look correct and work correctly. Created attachment 15635 [details] [review] [SIGNED-OFF] Bug 9694 - Remove YUI styling from buttons on the patron card creator manage pages Buttons on the patron card creator's manage pages (manage templates, manage profiles, etc) are styled using YUI. They can be classified as submit buttons rather than toolbar buttons, so they should have default submit button styles. This patch removes YUI styling and related JavaScript. Other minor changes: Escaping strings in JavaScript for translation. To test, view the patron card creator's manage page for layouts, templates, profiles, and batches. "Edit," "Delete," and "Export" buttons should look correct and work correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. On errors. Tested all manage pages, edit, delete, and export buttons. Created attachment 15875 [details] [review] [PASSED QA] Bug 9694 - Remove YUI styling from buttons on the patron card creator manage pages Buttons on the patron card creator's manage pages (manage templates, manage profiles, etc) are styled using YUI. They can be classified as submit buttons rather than toolbar buttons, so they should have default submit button styles. This patch removes YUI styling and related JavaScript. Other minor changes: Escaping strings in JavaScript for translation. To test, view the patron card creator's manage page for layouts, templates, profiles, and batches. "Edit," "Delete," and "Export" buttons should look correct and work correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. On errors. Tested all manage pages, edit, delete, and export buttons. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, improves consistency. This patch has been pushed to master. |