Summary: | Replace YUI buttons on patron card creator manage toolbar with Bootstrap | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | bgkriegel |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/patroncards/manage.pl | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 9698 - Replace YUI buttons on patron card creator manage toolbar with Bootstrap
[SIGNED-OFF] Bug 9698 - Replace YUI buttons on patron card creator manage toolbar with Bootstrap [PASSED QA] Bug 9698 - Replace YUI buttons on patron card creator manage toolbar with Bootstrap |
Description
Owen Leonard
2013-02-22 15:44:46 UTC
Created attachment 15625 [details] [review] Bug 9698 - Replace YUI buttons on patron card creator manage toolbar with Bootstrap This patch converts the toolbar include file used by the patron card creator home and manage pages to Bootstrap, replacing YUI button and menu code with Bootstrap markup. This patch converts the previous menu buttons to plain buttons, removing the redundant links to the manage pages, which are in the left-hand sidebar. This keeps toolbar buttons within the general category of "action" (as opposed to "view"). To test, view the patron card creator home page and any manage page ("Manage layouts," "Manage profiles," etc). Buttons should look correct and work correctly. Created attachment 15641 [details] [review] [SIGNED-OFF] Bug 9698 - Replace YUI buttons on patron card creator manage toolbar with Bootstrap This patch converts the toolbar include file used by the patron card creator home and manage pages to Bootstrap, replacing YUI button and menu code with Bootstrap markup. This patch converts the previous menu buttons to plain buttons, removing the redundant links to the manage pages, which are in the left-hand sidebar. This keeps toolbar buttons within the general category of "action" (as opposed to "view"). To test, view the patron card creator home page and any manage page ("Manage layouts," "Manage profiles," etc). Buttons should look correct and work correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. No "plus" sign for this buttons? Created attachment 15874 [details] [review] [PASSED QA] Bug 9698 - Replace YUI buttons on patron card creator manage toolbar with Bootstrap This patch converts the toolbar include file used by the patron card creator home and manage pages to Bootstrap, replacing YUI button and menu code with Bootstrap markup. This patch converts the previous menu buttons to plain buttons, removing the redundant links to the manage pages, which are in the left-hand sidebar. This keeps toolbar buttons within the general category of "action" (as opposed to "view"). To test, view the patron card creator home page and any manage page ("Manage layouts," "Manage profiles," etc). Buttons should look correct and work correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. No "plus" sign for this buttons? Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> No plus signs? :) Works nicely and didn't have the plus before, so it's ok. This patch has been pushed to master. Plus sign icons would be a nice follow-up. |