Summary: | OPACPopupAuthorsSearch ugly in CSSR | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | OPAC | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | major | ||
Priority: | P5 - low | CC: | jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 5888 | ||
Bug Blocks: | |||
Attachments: |
cssr and OPACPopupAuthorsSearch
prog and OPACPopupAuthorsSearch Bug 9711: Add css style for OPACPopupAuthorsSearch [SIGNED-OFF] Bug 9711: Add css style for OPACPopupAuthorsSearch [PASSED QA] Bug 9711: Add css style for OPACPopupAuthorsSearch |
Created attachment 15666 [details]
prog and OPACPopupAuthorsSearch
Looks good
Created attachment 15676 [details] [review] Bug 9711: Add css style for OPACPopupAuthorsSearch Bug 5888 introduces a new syspref OPACPopupAuthorsSearch. If enabled, a popup is displayed on the OPAC detail page. This development does not add the css for the ccsr theme. Test plan: Enable the OPACPopupAuthorsSearch. Check that the appearance is the same of prog and ccsr themes. Created attachment 15679 [details] [review] [SIGNED-OFF] Bug 9711: Add css style for OPACPopupAuthorsSearch Bug 5888 introduces a new syspref OPACPopupAuthorsSearch. If enabled, a popup is displayed on the OPAC detail page. This development does not add the css for the ccsr theme. Test plan: Enable the OPACPopupAuthorsSearch. Check that the appearance is the same of prog and ccsr themes. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Tested on several authorities (authors, subjects, etc) works as expected It seems I can't get this to work with my data - no checkboxes appear. Can I get some more information about the new pref and about the conditions for the checkboxes to appear? (In reply to comment #4) > It seems I can't get this to work with my data - no checkboxes appear. > Can I get some more information about the new pref and about the conditions > for the checkboxes to appear? Katrin, you must have Additional authors and/or Subject(s) for your record. Checkboxes appear when clicking on one of them. Hi Jonathan, I had checked records with more than one other shown in the by line - is there more to it? Which fields? It is not the "by" line but the "Additional authors:" and "Subject(s):" lines. I am sorry, I can't get this to feature to show up for me. If you want me to look at it again please provide a detailed step by step test plan and information on how the MARC record has to look like. I am removing myself as QA contact - maybe someone else has the right data to QA this. Katrin, The "additionnal authors" links are filled with the result of the C4::Biblio::GetMarcAuthors routine. So for UNIMARC, with fields 700 to 712 (without $3 et $5) and for others MARC flavors fields are 700 to 720. For subjects: UNIMARC 600 to 611 without $2, $3, $4, $5 ; others MARC flavors: 600 to 699 (without $2 for MARC21) If you fill a least one of these fields, you should see the feature. I can provide an export of one of my notices if you have an UNIMARC install. Created attachment 16129 [details] [review] [PASSED QA] Bug 9711: Add css style for OPACPopupAuthorsSearch Bug 5888 introduces a new syspref OPACPopupAuthorsSearch. If enabled, a popup is displayed on the OPAC detail page. This development does not add the css for the ccsr theme. Test plan: Enable the OPACPopupAuthorsSearch. Check that the appearance is the same of prog and ccsr themes. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Tested on several authorities (authors, subjects, etc) works as expected Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Test plan: 1) Switch to CCSR theme 2) Turn off XSLT views (leaving prefs empty) 3) Turn on OPACPopupAuthorsSearch > Confirm layout is ok/broken in OPAC 4) Switch back to prog theme > Confirm layout is ok/broken in OPAC 5) Switch off OPACPopupAuthorsSearch > Confirm layout is ok/broken in OPAC 6) Switch back to CCSR > Confirm layout is ok/broken in OPAC Done. Note: Feature only works with normal view (no XSLT) This patch has been pushed to master. |
Created attachment 15665 [details] cssr and OPACPopupAuthorsSearch When you have OPACPopupAuthorsSearch set to show the checkboxes in CCSR it looks horrible - see attached.