Bug 9718

Summary: Add POD and comments for Check_Userid and Generate_Userid subs
Product: Koha Reporter: David Cook <dcook>
Component: PatronsAssignee: David Cook <dcook>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P5 - low CC: gmcharlt, kyle.m.hall
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 9718 - Add POD and comments for Check_Userid and Generate_Userid subs
Bug 9718 - Add POD and comments for Check_Userid and Generate_Userid subs
[PASSED QA] Bug 9718 - Add POD and comments for Check_Userid and Generate_Userid subs

Description David Cook 2013-02-27 04:29:58 UTC
Add plain English explanations in POD blocks for how the Check_Userid and Generate_Userid subs work.

Also add a comment explaining how the do loop works with the while condition in Generate_Userid, since the condition is worded awkwardly.
Comment 1 David Cook 2013-02-27 04:32:49 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2013-02-28 06:38:34 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-03-21 07:58:42 UTC
Created attachment 16565 [details] [review]
[PASSED QA] Bug 9718 - Add POD and comments for Check_Userid and Generate_Userid subs

Add plain English explanations in POD blocks for how the Check_Userid and Generate_Userid subs work.

Also add a comment explaining how the do loop works with the while condition in Generate_Userid, since the condition is worded awkwardly.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
String patch adding documentation.
POD test and other tests pass.
Comment 4 Jared Camins-Esakov 2013-03-21 13:57:33 UTC
This patch has been pushed to master.