Summary: | Add POD and comments for Check_Userid and Generate_Userid subs | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | Patrons | Assignee: | David Cook <dcook> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt, kyle.m.hall |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 9718 - Add POD and comments for Check_Userid and Generate_Userid subs
Bug 9718 - Add POD and comments for Check_Userid and Generate_Userid subs [PASSED QA] Bug 9718 - Add POD and comments for Check_Userid and Generate_Userid subs |
Description
David Cook
2013-02-27 04:29:58 UTC
Created attachment 15719 [details] [review] Bug 9718 - Add POD and comments for Check_Userid and Generate_Userid subs Add plain English explanations in POD blocks for how the Check_Userid and Generate_Userid subs work. Also add a comment explaining how the do loop works with the while condition in Generate_Userid, since the condition is worded awkwardly. Created attachment 15751 [details] [review] Bug 9718 - Add POD and comments for Check_Userid and Generate_Userid subs Add plain English explanations in POD blocks for how the Check_Userid and Generate_Userid subs work. Also add a comment explaining how the do loop works with the while condition in Generate_Userid, since the condition is worded awkwardly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 16565 [details] [review] [PASSED QA] Bug 9718 - Add POD and comments for Check_Userid and Generate_Userid subs Add plain English explanations in POD blocks for how the Check_Userid and Generate_Userid subs work. Also add a comment explaining how the do loop works with the while condition in Generate_Userid, since the condition is worded awkwardly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> String patch adding documentation. POD test and other tests pass. This patch has been pushed to master. |