| Summary: | Typo in code causes compilation failure with Solr enabled | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Colin Campbell <colin.campbell> |
| Component: | Architecture, internals, and plumbing | Assignee: | Colin Campbell <colin.campbell> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | chris |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Proposed patch
Bug 9727: Fix typo in variable name Bug 9727: Fix typo in variable name [PASSED QA] Bug 9727: Fix typo in variable name [PASSED QA] Bug 9727: Fix typo in variable name |
||
|
Description
Colin Campbell
2013-02-28 09:56:43 UTC
Created attachment 15757 [details] [review] Proposed patch To test see example in bug description Created attachment 15758 [details] [review] Bug 9727: Fix typo in variable name Variable is passed as recordtype not record_type correct name Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> before applying the patch $ perl -wc Koha/SearchEngine/Solr/Index.pm Global symbol "$record_type" requires explicit package name at Koha/SearchEngine/Solr/Index.pm line 43. Koha/SearchEngine/Solr/Index.pm had compilation errors. after Koha/SearchEngine/Solr/Index.pm syntax OK Created attachment 16254 [details] [review] Bug 9727: Fix typo in variable name Variable is passed as recordtype not record_type correct name Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> before applying the patch $ perl -wc Koha/SearchEngine/Solr/Index.pm Global symbol "$record_type" requires explicit package name at Koha/SearchEngine/Solr/Index.pm line 43. Koha/SearchEngine/Solr/Index.pm had compilation errors. after Koha/SearchEngine/Solr/Index.pm syntax OK Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> Created attachment 16325 [details] [review] [PASSED QA] Bug 9727: Fix typo in variable name Variable is passed as recordtype not record_type correct name Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> before applying the patch $ perl -wc Koha/SearchEngine/Solr/Index.pm Global symbol "$record_type" requires explicit package name at Koha/SearchEngine/Solr/Index.pm line 43. Koha/SearchEngine/Solr/Index.pm had compilation errors. after Koha/SearchEngine/Solr/Index.pm syntax OK Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> I can't really test this with solr, but as various people at the hackfest have confirmed this to be fixing the problem I feel save to pass QA. Also change looks quite logical. all tests and QA script pass. Created attachment 16326 [details] [review] [PASSED QA] Bug 9727: Fix typo in variable name Variable is passed as recordtype not record_type correct name Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> before applying the patch $ perl -wc Koha/SearchEngine/Solr/Index.pm Global symbol "$record_type" requires explicit package name at Koha/SearchEngine/Solr/Index.pm line 43. Koha/SearchEngine/Solr/Index.pm had compilation errors. after Koha/SearchEngine/Solr/Index.pm syntax OK Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> I can't really test this with solr, but as various people at the hackfest have confirmed this to be fixing the problem I feel save to pass QA. All tests and QA script pass too. This patch has been pushed to master. Pushed to 3.10.x will be in 3.10.5 |