Description
Tomás Cohen Arazi (tcohen)
2013-02-28 15:19:28 UTC
Created attachment 15772 [details] [review] Bug 9731 - Remove changelanguage.pl in favor of (already present) opac-changelanguage.pl Remove that file that duplicates the behaviour of the correct opac-changelanguage.pl file and fix references to it in the templates. To+ Sponsored-by: Universidad Nacional de Córdoba To test: - Apply the patch - Choose a different language in the OPAC - It should work as expected. Created attachment 16267 [details] [review] [SIGNED-OFF] Bug 9731 - Remove changelanguage.pl in favor of opac-changelanguage.pl Remove that file that duplicates the behaviour of the correct opac-changelanguage.pl file and fix references to it in the templates. To test: - Apply the patch - Choose a different language in the OPAC - It should work as expected. To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> fatal: cannot convert from UTF-8utf-8 to UTF-8 Owen, your submitted patch is bad-formatted, please resubmit it. Created attachment 16273 [details] [review] [SIGNED-OFF] Bug 9731 - Remove changelanguage.pl in favor of opac-changelanguage.pl Remove that file that duplicates the behaviour of the correct opac-changelanguage.pl file and fix references to it in the templates. To test: - Apply the patch - Choose a different language in the OPAC - It should work as expected. To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> QA comment: This patch replaces all occurrences of opac/changelanguage.pl with opac/opac-changelanguage.pl. These 2 scripts do the same job, it is useless to have both. Marked as Passed QA. Created attachment 16318 [details] [review] Bug 9731 - Remove changelanguage.pl in favor of opac-changelanguage.pl Remove that file that duplicates the behaviour of the correct opac-changelanguage.pl file and fix references to it in the templates. To test: - Apply the patch - Choose a different language in the OPAC - It should work as expected. To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 16451 [details] [review] Bug 9731 - Remove changelanguage.pl in favor of opac-changelanguage.pl Remove that file that duplicates the behaviour of the correct opac-changelanguage.pl file and fix references to it in the templates. To test: - Apply the patch - Choose a different language in the OPAC - It should work as expected. To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Tested again at RM's request Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> This patch has been pushed to master. |